Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLUGIN REQUEST] harpoon2 #1440

Open
nicolasauler opened this issue Apr 21, 2024 · 5 comments
Open

[PLUGIN REQUEST] harpoon2 #1440

nicolasauler opened this issue Apr 21, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@nicolasauler
Copy link

nicolasauler commented Apr 21, 2024

Field Description
Plugin harpoon2
Homepage https://github.com/ThePrimeagen/harpoon/tree/harpoon2
Nixpkgs https://search.nixos.org/packages?channel=unstable&show=vimPlugins.harpoon2&from=0&size=50&sort=relevance&type=packages&query=harpoon2

Extra Information

harpoon2 introduces breaking changes to harpoon (1)

@nicolasauler nicolasauler added the enhancement New feature or request label Apr 21, 2024
@4lxs
Copy link
Contributor

4lxs commented Apr 23, 2024

i am pretty sure this has been discussed and decided that we're waiting for harpoon2 to become the default before switching.

@GaetanLepage
Copy link
Member

Indeed. Harpoon 2 has not yet been officially released. Hence, in the meantime, we will sick on harpoon 1. I have already started to adapt the nixvim module on my side.

I will leave this issue open to track this migration.

@nicolasauler
Copy link
Author

i am pretty sure this has been discussed and decided that we're waiting for harpoon2 to become the default before switching.

Sorry mate!
I checked the issues for anything harpoon2 related, but couldn't find any open or closed ones, that's why I opened this one.

I will leave this issue open to track this migration.

Great! Thanks Gaetan.

@GaetanLepage
Copy link
Member

Sorry mate!
I checked the issues for anything harpoon2 related, but couldn't find any open or closed ones, that's why I opened this one.

No problem :) Maybe it was on the matrix or somewhere else, I don't remember.

@MattSturgeon
Copy link
Member

As per discussion on matrix, I think we should add harpoon2 alongside harpoon.

  • Rename plugins.harpoon to plugins.harpoon1
  • Add pluigins.harpoon2
  • Add a "transition alias" pointing to either plugins.harpoon1 or plugins.harpoon2
  • Print a warning when the alias is used, such as:
    "plugins.harpoon is an alias for plugins.harpoon1. After 24.11 plugins.harpoon2 will be moved to plugins.harpoon. Use plugins.harpoon1 or plugins.harpoon2 to silence this warning"

One thing I don't like about this approach, is it implies we will always have three plugins.harpoon* modules (one of which being an alias), though idk if that's a real issue or just a small ugliness?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants