Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fast row values pagination #11

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fast row values pagination #11

wants to merge 2 commits into from

Conversation

nitely
Copy link
Owner

@nitely nitely commented Oct 9, 2020

Fixes #9
Related #8

Implements the "row values" variation.

Benchmark without index, 1M rows; 4 sort fields; page 80K; article 800K:

Offset/Limit 1.692431215000397
Seek Method 0.3435570509991521

Benchmark with index, 1M rows; 4 sort fields; page 80K; article 800K:

Offset/Limit 0.10353935199964326
Seek Method 0.0020750300009240163

@nitely
Copy link
Owner Author

nitely commented Oct 10, 2020 •
edited
Loading

This cannot be merged as is. The "row variation" doesn't support mixing the sort direction, all fields must be either ASC or DESC. This implementation does not support relationships (ex: foo__bar) on the filter/sort fields. It seems to work on sqlite and postgresql, but it won't work on Oracle, and idk about mysql. It may not work with every field; I've tested it with BooleanField, DatetimeField, and IntegerField.

I think there should be a parameter that enables this, like fast_mode=True or something.

@nitely nitely changed the title Fast row values paginator Fast row values pagination Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement fast "row values" variant
1 participant
@nitely