Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

developer installation doc needs to be updated #615

Closed
yibeichan opened this issue Jan 2, 2023 · 6 comments
Closed

developer installation doc needs to be updated #615

yibeichan opened this issue Jan 2, 2023 · 6 comments

Comments

@yibeichan
Copy link
Collaborator

in Readme, Developer installation is illustrated as the following:

Pydra requires Python 3.7+. To install in developer mode:
git clone [email protected]:nipype/pydra.git
cd pydra
pip install -e ".[dev]"

However, after the recent update, setup.cfg has been removed; instead, pyproject.toml has been used.
pip install -e ".[dev]" needs to be updated. So does pip install -e ".[dask]"

Happy New Year!

@effigies
Copy link
Contributor

effigies commented Jan 2, 2023

I'm not seeing what the issue is. Does pip install -e ".[dev]" not work for you? What version of pip are you using?

@yibeichan
Copy link
Collaborator Author

Yes! I got this error

ERROR: File "setup.py" or "setup.cfg" not found. Directory cannot be installed in editable mode: /Users/yibeichen/GDrive/GitHub/pydra
(A "pyproject.toml" file was found, but editable mode currently requires a setuptools-based build.)

my pip version is pip 21.2.2 from /Users/yibeichen/miniconda3/envs/pydra/lib/python3.7/site-packages/pip (python 3.7)

@ghisvail
Copy link
Collaborator

ghisvail commented Jan 2, 2023

You need at least Pip version 21.3 which supports PEP-610.

@yibeichan
Copy link
Collaborator Author

thank you! well I just realized that I can upgrade pip and try it again. So I did... and it works.....

@ghisvail
Copy link
Collaborator

ghisvail commented Jan 2, 2023

I am used to running pip install --upgrade pip whenever I instantiate a new virtual environment, so I had to look it up to find the exact version which introduced the necessary support.

@yibeichan
Copy link
Collaborator Author

Thanks for the tips! I had this conda env last summer and didn't upgrade it for a while...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants