-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What is the desired behaviour when input_spec isn't provided to Workflow __init__? #491
Comments
@tclose - thanks for reporting this! we should raise an exception. Would you be interested in creating PR? |
Sure, do you want an empty |
No, I think we want to have an error, we do want to have at least one input for every single workflow and discourage people from hard-coding input paths etc. Unless, you have an example that you can show it will be useful |
#497 addresses this issue |
One thing that seems a little counterintuitive to me unless I don't understand how it works (quite likely) is the ability to define both the input_spec and input values in the Workflow init. I was expecting a Workflow to conceptually map onto a task (i.e. an "uninstantiated node", sorry not sure what nomeclature you use), which then could be parameterised for different applications. However, it seems that you are parameterising it as it is defined, do I have that right? |
I think the main reason for |
This is now addressed by #497 |
pydra/pydra/engine/core.py
Lines 796 to 817 in e0ea60d
If an
input_spec
isn't provided to Workflow.init what should happen, an emptyinput_spec
generated? Because as it standsself.input_spec
isn't set and the method gets stuck in an infinite loop trying to access the attribute that isn't there.The text was updated successfully, but these errors were encountered: