auth login in non-interactive env should not block #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelkuc
force-pushed
the
not-block-with-no-tty
branch
2 times, most recently
from
c1b8813 to
bc278b0
Compare
There was a problem hiding this comment.
I am not sure why we have to add this specific option to the context and then have to change so many function calls (just because of that one option). For example, why do we need that interactive env information in the format.getPrinter function? Maybe you could help me in understanding this?
pawelkuc
force-pushed
the
not-block-with-no-tty
branch
2 times, most recently
from
9bb6cf3 to
e4e402b
Compare
…ould not block If you execute `nctl auth login` in a non-interactive environment (e.g. CI/CD) and forget to set `--api-token`, the browser should not try to open - you should see an error message instead.
pawelkuc
force-pushed
the
not-block-with-no-tty
branch
from
e4e402b to
efa74be
Compare
thirdeyenick
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you execute
nctl auth loginin a non-interactive environment (e.g. CI/CD) and forget to set--api-token, the browser should not try to open - you should see an error message instead.