Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include instruction to use JAVA 1.8 #308

Open
blyscuit opened this issue Sep 13, 2022 · 3 comments
Open

Include instruction to use JAVA 1.8 #308

blyscuit opened this issue Sep 13, 2022 · 3 comments

Comments

@blyscuit
Copy link

Why

Running with JAVA 11 will cause the script to fail. The readme should specify Environment of JAVA 8 or any other JAVA versions.

JAVA 8

Screen Shot 2022-09-13 at 15 43 27

JAVA 11

Screen Shot 2022-09-13 at 15 43 30

Screen Shot 2022-09-13 at 15 44 06

Acceptance Criteria

Add Environment section to readme and specify JAVA 8.

Who Benefits?

User.

@blyscuit
Copy link
Author

Please ignore and close this if it's related to the first set up test only and the project is correctly generated with JAVA 11.

@sleepylee
Copy link
Member

as of now, the generated project only supports JAVA 8, it has been a decade like this so it's a very common setup for android dev 😓

recently, Java 11 has been supported since Android Studio 3.0 in 2020: https://developer.android.com/studio/releases/gradle-plugin?utm_source=android-studio-2020-3-1&utm_medium=studio-assistant-stable#java-11

So the actual request is: should we support Java 11 from the generated codebase as well?

The latest java version is 16, so actually, it might be a valid Note to add on the Prerequisite anw 👍

@kaungkhantsoe
Copy link
Contributor

kaungkhantsoe commented Jun 16, 2023

@blyscuit Do you still have this issue? I tried on both Java 11 and 17, and I could build the project successfully. cc @sleepylee

JAVA 17
Screenshot 2023-06-16 at 4 04 07 PM

JAVA 11
Screenshot 2023-06-16 at 4 05 43 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants