From 993b035f03525b05feb16eff331f47724dca2d42 Mon Sep 17 00:00:00 2001 From: Long Nguyen Date: Sun, 15 Aug 2021 23:05:23 +0700 Subject: [PATCH 1/6] Add the Github release PR template --- .../PULL_REQUEST_TEMPLATE/RELEASE_TEMPLATE.md | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE/RELEASE_TEMPLATE.md diff --git a/.github/PULL_REQUEST_TEMPLATE/RELEASE_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE/RELEASE_TEMPLATE.md new file mode 100644 index 000000000..819fd5916 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE/RELEASE_TEMPLATE.md @@ -0,0 +1,17 @@ +Link to the milestone on Github e.g. https://github.com/nimblehq/git-templates/milestone/41?closed=1 +or +Link to the project management tool for the release + +## Features + +Provide the ID and title of the issue in the section for each type (feature, chore and bug). The link is optional. + +- [ch1234] As a user, I can log in + or +- [[ch1234](https://github.com/nimblehq/git-templates/issues/1234)] As a user, I can log in + +## Chores +- Same structure as in ## Feature + +## Bugs +- Same structure as in ## Feature From 9ad3f026ce672eae7aae9d3611945a5b3423b562 Mon Sep 17 00:00:00 2001 From: Long Nguyen Date: Wed, 18 Aug 2021 16:32:14 +0700 Subject: [PATCH 2/6] Add a guide for using release PR template --- .github/PULL_REQUEST_TEMPLATE.md | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index fc4633bae..a1eda23a7 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,13 +1,17 @@ +Note: for a release PR, append this parameter `?template=release_template.md` to the current URL to apply the release PR template, e.g. `{Github PR URL}?template=release_template.md` + +-- + https://github.com/nimblehq/android-templates/issues/?? ## What happened 👀 -Describe the big picture of your changes here to communicate to the team why we should accept this pull request. - +Describe the big picture of your changes here to communicate to the team why we should accept this pull request. + ## Insight 📝 Describe in details how to test the changes, which solution you tried but did not go with, referenced documentation is welcome as well. - + ## Proof Of Work 📹 Show us the implementation: screenshots, gif, etc. From 80960fae2daab0bfa6e70019daea1c1a45e7b8e4 Mon Sep 17 00:00:00 2001 From: tuubz Date: Wed, 25 Aug 2021 16:34:26 +0700 Subject: [PATCH 3/6] [#117] Add network security config for RxJavaTemplate --- .../main/res/xml/network_security_config.xml | 7 +----- .../res/xml/network_security_config.xml | 22 +++++++++++++++++++ .../common/secrets/ApiEndpointUrlImpl.kt | 2 +- 3 files changed, 24 insertions(+), 7 deletions(-) create mode 100644 RxJavaTemplate/app/src/staging/res/xml/network_security_config.xml diff --git a/RxJavaTemplate/app/src/main/res/xml/network_security_config.xml b/RxJavaTemplate/app/src/main/res/xml/network_security_config.xml index 4a42e0f61..336e404f3 100644 --- a/RxJavaTemplate/app/src/main/res/xml/network_security_config.xml +++ b/RxJavaTemplate/app/src/main/res/xml/network_security_config.xml @@ -1,6 +1 @@ - - - - monkeyuser.com - - + \ No newline at end of file diff --git a/RxJavaTemplate/app/src/staging/res/xml/network_security_config.xml b/RxJavaTemplate/app/src/staging/res/xml/network_security_config.xml new file mode 100644 index 000000000..3e4891f11 --- /dev/null +++ b/RxJavaTemplate/app/src/staging/res/xml/network_security_config.xml @@ -0,0 +1,22 @@ + + + + + + + + + + + + + + + + www.reddit.com + + + + + + \ No newline at end of file diff --git a/RxJavaTemplate/data/src/production/java/co/nimblehq/rxjava/data/service/common/secrets/ApiEndpointUrlImpl.kt b/RxJavaTemplate/data/src/production/java/co/nimblehq/rxjava/data/service/common/secrets/ApiEndpointUrlImpl.kt index 60cac4bc9..6a514dcb5 100644 --- a/RxJavaTemplate/data/src/production/java/co/nimblehq/rxjava/data/service/common/secrets/ApiEndpointUrlImpl.kt +++ b/RxJavaTemplate/data/src/production/java/co/nimblehq/rxjava/data/service/common/secrets/ApiEndpointUrlImpl.kt @@ -2,5 +2,5 @@ package co.nimblehq.rxjava.data.service.common.secrets class ApiEndpointUrlImpl : ApiEndpointUrl { override val value: String - get() = TODO("Not implement yet, please modify this for your Production usage") + get() = "https://www.reddit.com/" } From a7cd6e354f239790d3bd5ad09bce9a3cee16603b Mon Sep 17 00:00:00 2001 From: tuubz Date: Mon, 30 Aug 2021 10:28:41 +0700 Subject: [PATCH 4/6] [#117] Add network security config for CoroutineTemplate --- .../app/src/main/AndroidManifest.xml | 1 + .../main/res/xml/network_security_config.xml | 1 + .../res/xml/network_security_config.xml | 22 +++++++++++++++++++ 3 files changed, 24 insertions(+) create mode 100644 CoroutineTemplate/app/src/main/res/xml/network_security_config.xml create mode 100644 CoroutineTemplate/app/src/staging/res/xml/network_security_config.xml diff --git a/CoroutineTemplate/app/src/main/AndroidManifest.xml b/CoroutineTemplate/app/src/main/AndroidManifest.xml index b29821e14..38931a2b0 100644 --- a/CoroutineTemplate/app/src/main/AndroidManifest.xml +++ b/CoroutineTemplate/app/src/main/AndroidManifest.xml @@ -9,6 +9,7 @@ android:allowBackup="true" android:icon="@mipmap/ic_launcher" android:label="@string/app_name" + android:networkSecurityConfig="@xml/network_security_config" android:roundIcon="@mipmap/ic_launcher_round" android:supportsRtl="true" android:theme="@style/AppTheme"> diff --git a/CoroutineTemplate/app/src/main/res/xml/network_security_config.xml b/CoroutineTemplate/app/src/main/res/xml/network_security_config.xml new file mode 100644 index 000000000..336e404f3 --- /dev/null +++ b/CoroutineTemplate/app/src/main/res/xml/network_security_config.xml @@ -0,0 +1 @@ + \ No newline at end of file diff --git a/CoroutineTemplate/app/src/staging/res/xml/network_security_config.xml b/CoroutineTemplate/app/src/staging/res/xml/network_security_config.xml new file mode 100644 index 000000000..a201cb709 --- /dev/null +++ b/CoroutineTemplate/app/src/staging/res/xml/network_security_config.xml @@ -0,0 +1,22 @@ + + + + + + + + + + + + + + + + www.jsonplaceholder.typicode.com + + + + + + \ No newline at end of file From e9edad9093adb981faf7efd21ba37832a93afd85 Mon Sep 17 00:00:00 2001 From: tuubz Date: Mon, 30 Aug 2021 11:27:01 +0700 Subject: [PATCH 5/6] [#117] Apply code review changes --- .../app/src/main/res/xml/network_security_config.xml | 2 +- .../src/staging/res/xml/network_security_config.xml | 10 +++------- .../app/src/main/res/xml/network_security_config.xml | 2 +- .../src/staging/res/xml/network_security_config.xml | 10 +++------- 4 files changed, 8 insertions(+), 16 deletions(-) diff --git a/CoroutineTemplate/app/src/main/res/xml/network_security_config.xml b/CoroutineTemplate/app/src/main/res/xml/network_security_config.xml index 336e404f3..04ead227c 100644 --- a/CoroutineTemplate/app/src/main/res/xml/network_security_config.xml +++ b/CoroutineTemplate/app/src/main/res/xml/network_security_config.xml @@ -1 +1 @@ - \ No newline at end of file + diff --git a/CoroutineTemplate/app/src/staging/res/xml/network_security_config.xml b/CoroutineTemplate/app/src/staging/res/xml/network_security_config.xml index a201cb709..2a99cd31b 100644 --- a/CoroutineTemplate/app/src/staging/res/xml/network_security_config.xml +++ b/CoroutineTemplate/app/src/staging/res/xml/network_security_config.xml @@ -1,22 +1,18 @@ + - - - - - - + www.jsonplaceholder.typicode.com - \ No newline at end of file + diff --git a/RxJavaTemplate/app/src/main/res/xml/network_security_config.xml b/RxJavaTemplate/app/src/main/res/xml/network_security_config.xml index 336e404f3..04ead227c 100644 --- a/RxJavaTemplate/app/src/main/res/xml/network_security_config.xml +++ b/RxJavaTemplate/app/src/main/res/xml/network_security_config.xml @@ -1 +1 @@ - \ No newline at end of file + diff --git a/RxJavaTemplate/app/src/staging/res/xml/network_security_config.xml b/RxJavaTemplate/app/src/staging/res/xml/network_security_config.xml index 3e4891f11..7556e495f 100644 --- a/RxJavaTemplate/app/src/staging/res/xml/network_security_config.xml +++ b/RxJavaTemplate/app/src/staging/res/xml/network_security_config.xml @@ -1,22 +1,18 @@ + - - - - - - + www.reddit.com - \ No newline at end of file + From 805e80ae736276a4068914c9136df956e812452c Mon Sep 17 00:00:00 2001 From: hoangnguyen92dn Date: Tue, 31 Aug 2021 10:04:18 +0700 Subject: [PATCH 6/6] [#122] Add Story template --- .github/ISSUE_TEMPLATE/story_template.md | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/story_template.md diff --git a/.github/ISSUE_TEMPLATE/story_template.md b/.github/ISSUE_TEMPLATE/story_template.md new file mode 100644 index 000000000..9d5c11083 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/story_template.md @@ -0,0 +1,22 @@ +--- +name: "Story" +about: "Open a feature story" +title: "[Type] As a user, I can " +labels: "type : feature" +--- + +## Why + +Describe the idea of the user story as in what the motive of the user story is. + +## Acceptance Criteria + +List down how the user story will be tested and what criteria are necessary for the user story to be accepted. + +## Design + +(Optional) Add design screenshots or Figma links for UI/UX-related stories. + +## Resources + +(Optional) Add useful resources such as links to documentation, implementation ideas, or best practices.