Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working with Rematch 5 #4

Open
elmoonfire opened this issue Nov 8, 2023 · 2 comments
Open

Not working with Rematch 5 #4

elmoonfire opened this issue Nov 8, 2023 · 2 comments

Comments

@elmoonfire
Copy link

Description
It appears this addon has a compatibility issue with the new Rematch 5 which was just released in their stable build channel.

NihilistzscheUI Version
1.3.0

ElvUI Version
13.47

Steps to Reproduce
Just loaded the game

Expected Behavior
No error and functioning

Actual Behavior
Error message below and the skin doesn't seem to be applied

Mention what addons you are using.
I'm using a lot of addons but the error message doesn't appear unless I use Rematch 5 instead of Rematch 4

Additional Information
Nothing additional

Error Log

Message: ...terface/AddOns/RematchElvUISkin/RematchElvUISkin.lua:605: attempt to call method 'ShowDialog' (a nil value)
Time: Tue Nov  7 17:47:28 2023
Count: 3
Stack: ...terface/AddOns/RematchElvUISkin/RematchElvUISkin.lua:605: attempt to call method 'ShowDialog' (a nil value)
[string "=[C]"]: in function `ShowDialog'
[string "@Interface/AddOns/RematchElvUISkin/RematchElvUISkin.lua"]:605: in function <...terface/AddOns/RematchElvUISkin/RematchElvUISkin.lua:599>

Locals: (*temporary) = <function> defined =[C]:-1

@MatthewRyanRead
Copy link

To add more info: The code appearing in the error tries to pop up an dialog window about the addon not working with Rematch 5, but that code itself does not work. I tried removing that locally but, as expected, the addon still does not work.

I'm sure it will be a significant change to make this work with Rematch 5, unfortunately!

@Fleymour
Copy link

I'm sure it will be a significant change to make this work with Rematch 5, unfortunately!

yeah new rematch broke elvui skin and tsmpetvalue .. hope those will update.. so lovly combination

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants