Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding presets params? #2

Open
RGX650 opened this issue Jan 11, 2024 · 4 comments
Open

Adding presets params? #2

RGX650 opened this issue Jan 11, 2024 · 4 comments

Comments

@RGX650
Copy link

RGX650 commented Jan 11, 2024

https://github.com/ouyanglixin/lora-layered-weight-tool.git
AUTOMATIC1111/stable-diffusion-webui#8153

@nihedon
Copy link
Owner

nihedon commented Jan 12, 2024

@RGX650

I apologize, but I'm not quite clear on what you're asking. Are you simply looking to add a preset?
If so, the presets for this extension are compatible with Lora Block Weight presets. By adding presets to Lora Block Weight, they will be displayed into this extension as well.

For instructions on how to add presets to Lora Block Weight, please refer to the README of Lora Block Weight.
https://github.com/hako-mikan/sd-webui-lora-block-weight?tab=readme-ov-file#fun-usage

thank you.

@RGX650
Copy link
Author

RGX650 commented Jan 12, 2024

I meant, that maybe in the popup window:
we could select presets in a dropdown, then they would be applied to the pop up sliders
For example: select "FACE" in the dropdown, then the related lbw params would be applied to the sliders as hint. This actually allows you to adjust them.
You could also have save preset / delete preset buttons.
Also, maybe an import button to get sd-webui-lora-block-weight presets to the sd-webui-weight-helper dropdown.

As a result the params are applied in the prompt display. Only params number, not the lbw name!
The lbw name should only be used by the sd-webui-lora-block-weight extension preset.

in sd-webui-lora-block-weight, the logic is different: when you save a preset "FACE", you can call it in prompt then the exact params are applied but it also means that you cannot adjust them anymore later, unless you change your preset in the sd-webui-lora-block-weight window.

@RGX650
Copy link
Author

RGX650 commented Jan 12, 2024

additionnally, i think it would be also usefull to have a button that can open a side panel to you popup window to see the block weight mapping regarding: FACE, HANDS, POSE, BACKGROUND, EYES, CLOTHING, etc with color code. so users could adjust the sliders with this reminder.

@nihedon
Copy link
Owner

nihedon commented Jan 15, 2024

@RGX650
Thank you for the additional clarification; I appreciate your explanation.
I find the idea intriguing, but it's important to note that this extension is primarily designed to assist with Lora Block Weight inputs. Therefore, the foundation is strictly based on Lora Block Weight.

While displaying hints for effective blocks like FACE or HANDS could be useful, it may not apply universally to all Lora. I would suggest exploring variations while referencing summary sites, such as the GitHub link you provided initially.

While developing this extension might be a consideration if there's widespread agreement, it's essential to acknowledge that it's a niche extension being developed on a smaller scale. At this time, I regret to inform you that adding this feature is not feasible.

I apologize if this doesn't align with your expectations, and I appreciate your understanding...
If you have any further questions or concerns, please feel free to let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants