Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Big children size issue #218

Open
urlimited opened this issue Aug 7, 2023 · 0 comments
Open

[Enhancement] Big children size issue #218

urlimited opened this issue Aug 7, 2023 · 0 comments

Comments

@urlimited
Copy link

urlimited commented Aug 7, 2023

Please fix me if I am wrong, but I believe for the cases when we have really big children nodes in the $children array property, the code might be crashed to the memory limit when we take $this->getChildren() in visitors.

In fact, would be great to make each visitor (TraversalPreOrder, TraversalPostOrder) via generators.
There is a yield visitor, but in fact, it does not have anything in common with the generator

@urlimited urlimited changed the title Generator Big children size issue Aug 7, 2023
@urlimited urlimited changed the title Big children size issue [Enhance] Big children size issue Aug 7, 2023
@urlimited urlimited changed the title [Enhance] Big children size issue [Enhancement] Big children size issue Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant