-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUILD TOOLS]: Replace Bundlesize #1764
Comments
This might be an easy drop-in replacement: Bundlewatch has an action too We could use something like this to push updates back to the PR... as long as we have a way to save or retrieve the bundle sizes as a json file. I think that we could use one of the internal bundlesize apis to fetch the file details (https://github.com/bundlewatch/bundlewatch/blob/98b7b789d40032b301351d2c0b02a1c443db2b7a/src/app/reporting/BundleWatchService/index.js#L40) |
@splincode This looks like a great alternative that was released recently: |
@markwhitfeld it's really interesting! what about add github action? |
@splincode Yeah, it looks like great integration! |
@rfprod since you’re a pro at GitHub actions, would you want to take this one also? |
@arturovt @markwhitfeld PS: |
@arturovt Yes, I can take this one, but most likely it will require collaboration in terms of creating a bundlemon project and adding secrets to the repo. |
Description
Bundlesize has issues comparing PR bundle sizes to master.
Updating the bundlesize manually in PRs is a real pain, and it doesn't give a comparison to master (because of issue siddharthkp/bundlesize#308). There must be something better!
We are probably also abusing the maxSize threshold prop by keeping it so close to the actual size and updating it all the time.
We need to investigate alternatives!
Some thoughts:
We really need 2 different things...
Maybe these could come from different tools
The text was updated successfully, but these errors were encountered: