diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml new file mode 100644 index 0000000..ea1f0da --- /dev/null +++ b/.github/workflows/build.yml @@ -0,0 +1,122 @@ +name: build + +on: [push, pull_request] + +permissions: read-all + +jobs: + build: + strategy: + matrix: + os: [ubuntu-24.04, macos-13, macos-14] + compiler: [gcc, clang] + + runs-on: ${{ matrix.os }} + + steps: + - uses: actions/checkout@v4 + with: + submodules: recursive + - name: Linux setup + if: runner.os == 'Linux' + run: | + sudo apt-get update + sudo apt-get install \ + g++-14 \ + clang-18 \ + autoconf \ + automake \ + autotools-dev \ + libtool \ + pkg-config + + # https://github.com/actions/runner-images/issues/9491#issuecomment-1989718917 + # Asan in llvm 14 provided in ubuntu 22.04 is incompatible with + # high-entropy ASLR in much newer kernels that GitHub runners are + # using leading to random crashes: https://reviews.llvm.org/D148280 + sudo sysctl vm.mmap_rnd_bits=28 + - name: MacOS setup + if: runner.os == 'macOS' + run: | + brew install autoconf automake libtool + - name: Setup clang (Linux) + if: runner.os == 'Linux' && matrix.compiler == 'clang' + run: | + echo 'CC=clang-18' >> $GITHUB_ENV + echo 'CXX=clang++-18' >> $GITHUB_ENV + - name: Setup clang (MacOS) + if: runner.os == 'macOS' && matrix.compiler == 'clang' + run: | + echo 'CC=clang' >> $GITHUB_ENV + echo 'CXX=clang++' >> $GITHUB_ENV + - name: Setup gcc (Linux) + if: runner.os == 'Linux' && matrix.compiler == 'gcc' + run: | + echo 'CC=gcc-14' >> $GITHUB_ENV + echo 'CXX=g++-14' >> $GITHUB_ENV + - name: Setup gcc (MacOS) + if: runner.os == 'macOS' && matrix.compiler == 'gcc' + run: | + echo 'CC=gcc' >> $GITHUB_ENV + echo 'CXX=g++' >> $GITHUB_ENV + - name: Enable ASAN + if: runner.os == 'Linux' + run: | + asanflags="-fsanitize=address,undefined -fno-sanitize-recover=undefined" + + LDFLAGS="$LDFLAGS $asanflags" + CFLAGS="$CFLAGS $asanflags -g3 -mavx2" + CXXFLAGS="$CXXFLAGS $asanflags -g3" + + echo 'LDFLAGS='"$LDFLAGS" >> $GITHUB_ENV + echo 'CFLAGS='"$CFLAGS" >> $GITHUB_ENV + echo 'CXXFLAGS='"$CXXFLAGS" >> $GITHUB_ENV + - name: Configure autotools + run: | + autoreconf -i && ./configure --disable-dependency-tracking + - name: Build urlparse with distcheck + run: | + make distcheck DISTCHECK_CONFIGURE_FLAGS="--enable-werror" + + build-cross: + strategy: + matrix: + host: [x86_64-w64-mingw32, i686-w64-mingw32] + + runs-on: ubuntu-24.04 + + env: + HOST: ${{ matrix.host }} + + steps: + - uses: actions/checkout@v4 + with: + submodules: recursive + - name: Prepare for i386 + if: matrix.host == 'i686-w64-mingw32' + run: | + sudo dpkg --add-architecture i386 + - name: Linux setup + run: | + sudo apt-get update + sudo apt-get install \ + gcc-mingw-w64 \ + autoconf \ + automake \ + autotools-dev \ + libtool \ + pkg-config \ + wine + - name: Configure autotools + run: | + autoreconf -i && \ + ./configure --disable-dependency-tracking --enable-werror \ + --host="$HOST" LIBS="-pthread" + - name: Build urlparse + run: | + make -j$(nproc) + make -j$(nproc) check TESTS="" + - name: Run tests + run: | + export WINEPATH="/usr/${{ matrix.host }}/lib;$(winepath -w /usr/lib/x86_64-linux-gnu/wine/x86_64-windows)" + wine test.exe diff --git a/m4/ax_check_compile_flag.m4 b/m4/ax_check_compile_flag.m4 new file mode 100644 index 0000000..ca36397 --- /dev/null +++ b/m4/ax_check_compile_flag.m4 @@ -0,0 +1,74 @@ +# =========================================================================== +# http://www.gnu.org/software/autoconf-archive/ax_check_compile_flag.html +# =========================================================================== +# +# SYNOPSIS +# +# AX_CHECK_COMPILE_FLAG(FLAG, [ACTION-SUCCESS], [ACTION-FAILURE], [EXTRA-FLAGS], [INPUT]) +# +# DESCRIPTION +# +# Check whether the given FLAG works with the current language's compiler +# or gives an error. (Warnings, however, are ignored) +# +# ACTION-SUCCESS/ACTION-FAILURE are shell commands to execute on +# success/failure. +# +# If EXTRA-FLAGS is defined, it is added to the current language's default +# flags (e.g. CFLAGS) when the check is done. The check is thus made with +# the flags: "CFLAGS EXTRA-FLAGS FLAG". This can for example be used to +# force the compiler to issue an error when a bad flag is given. +# +# INPUT gives an alternative input source to AC_COMPILE_IFELSE. +# +# NOTE: Implementation based on AX_CFLAGS_GCC_OPTION. Please keep this +# macro in sync with AX_CHECK_{PREPROC,LINK}_FLAG. +# +# LICENSE +# +# Copyright (c) 2008 Guido U. Draheim +# Copyright (c) 2011 Maarten Bosmans +# +# This program is free software: you can redistribute it and/or modify it +# under the terms of the GNU General Public License as published by the +# Free Software Foundation, either version 3 of the License, or (at your +# option) any later version. +# +# This program is distributed in the hope that it will be useful, but +# WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General +# Public License for more details. +# +# You should have received a copy of the GNU General Public License along +# with this program. If not, see . +# +# As a special exception, the respective Autoconf Macro's copyright owner +# gives unlimited permission to copy, distribute and modify the configure +# scripts that are the output of Autoconf when processing the Macro. You +# need not follow the terms of the GNU General Public License when using +# or distributing such scripts, even though portions of the text of the +# Macro appear in them. The GNU General Public License (GPL) does govern +# all other use of the material that constitutes the Autoconf Macro. +# +# This special exception to the GPL applies to versions of the Autoconf +# Macro released by the Autoconf Archive. When you make and distribute a +# modified version of the Autoconf Macro, you may extend this special +# exception to the GPL to apply to your modified version as well. + +#serial 4 + +AC_DEFUN([AX_CHECK_COMPILE_FLAG], +[AC_PREREQ(2.64)dnl for _AC_LANG_PREFIX and AS_VAR_IF +AS_VAR_PUSHDEF([CACHEVAR],[ax_cv_check_[]_AC_LANG_ABBREV[]flags_$4_$1])dnl +AC_CACHE_CHECK([whether _AC_LANG compiler accepts $1], CACHEVAR, [ + ax_check_save_flags=$[]_AC_LANG_PREFIX[]FLAGS + _AC_LANG_PREFIX[]FLAGS="$[]_AC_LANG_PREFIX[]FLAGS $4 $1" + AC_COMPILE_IFELSE([m4_default([$5],[AC_LANG_PROGRAM()])], + [AS_VAR_SET(CACHEVAR,[yes])], + [AS_VAR_SET(CACHEVAR,[no])]) + _AC_LANG_PREFIX[]FLAGS=$ax_check_save_flags]) +AS_VAR_IF(CACHEVAR,yes, + [m4_default([$2], :)], + [m4_default([$3], :)]) +AS_VAR_POPDEF([CACHEVAR])dnl +])dnl AX_CHECK_COMPILE_FLAGS diff --git a/urlparse.c b/urlparse.c index bdcdb51..cf5ad9f 100644 --- a/urlparse.c +++ b/urlparse.c @@ -128,7 +128,7 @@ static int urlparse_parser_eof(urlparse_parser *up) { static void urlparse_url_set_field_data(urlparse_url *dest, int field, const char *data, const char *start, const char *end) { - dest->field_set |= 1 << field; + dest->field_set |= (uint16_t)(1 << field); dest->field_data[field].off = (uint16_t)(start - data); dest->field_data[field].len = (uint16_t)(end - start); }