-
Notifications
You must be signed in to change notification settings - Fork 311
Unit tests are broken #321
Comments
anyone ? |
I'm really worried about the current state of ngrx, and I don't think I'm the only one. Their was almost no activity since last septembre on ngrx/store and ngrx/core. The master is broken, and doesn't permit to make any contribution. Even minor PR seems to be in "purgatory", since nobody try to review them. And their is still no real documentation on how to use ngrx/store and effects in a real life projet (with modularity, unit testing, etc ...). Some issue comments are even in conflict with some related v3 plans ... (About that, see : #197 , #281 (comment) and #128). And their is still no roadmap available. This project is really great, but even if we love to use it, I think a lot of people (me included) will, with regrets, choose to stop using it, in order to avoid the same dramatic issues that we had with Angular Material 1 this year (even if the problem here is really different, since ngrx/store v2.2.1 seems stable enough, and doesn't need some major fix) ! Please, tell us your plans, the reasons of the current state of this project, and permit us to contribute, if you haven't any developer available on your own. |
Thank you @fxck for this fast reaction. I understand the problem with NgModule / Lazy Loading, current workaround are ok, and nobody, I think, have major issue with that, nor with ngrx/store v2.2.1 in general. I'm more worried about this "issue" I reported, which doesn't permit to make any contribution for now, and the fact that I didn't have any information about that since two weeks ... Maybe I'm the one in cause here, but I really wanted to understand the problem in order to help to fix it if possible ... Having style issues (#320), missing imports (#324) and dependencies issues (#319) is a bit worrying ... |
So, after looking at 30544e9, I understand better now ... But why stopping any evolution on v2 in the meantime, keeping a broken master ? Couldn't this commit be cherry-picked and adapted to master, in order to permit to make minor evolutions and patches before april (Angular 4 being planned for march if I remember correctly) ? |
#269 (comment) Should gradually fix it now for Angular 4.0.0 |
Please check this against NgRx v4, and if it’s still an issue, please reopen on https://github.com/ngrx/platform. Thanks! |
this is a
development issue
description
After pulling the current master of ngrx/store, I did a
npm install
, thennpm test
, and it fails.node and OS versions
The following outputs are from node 6.9.4, on Windows 10, but I also tried this on 6.1.0 and 7.4.0, and get the same results.
issue
After fixing some other issues (see above), I still have the following output when running npm test :
Do somebody have any idea how I could fix that ?
previous fix
1. webpack version
Without any modification (last commit was b83e692), when running
npm test
, I get :This seems to be a known issue with webpack. Fixing its version to 2.1.0-beta.22 fix it. See #319.
2. Code Style (tslint)
I then get the following warnings :
I supposed that this could be one of the reasons why tests fails, so I fixed it (mainly some missing semicolon). See #320.
The text was updated successfully, but these errors were encountered: