Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing interceptors OpenConnector, Connect, ConnClose #5

Open
dolmen opened this issue Feb 5, 2021 · 1 comment
Open

Missing interceptors OpenConnector, Connect, ConnClose #5

dolmen opened this issue Feb 5, 2021 · 1 comment

Comments

@dolmen
Copy link

dolmen commented Feb 5, 2021

The interceptor lack callbacks for:

I propose to add the following callbacks:

  • OpenConnector(connector driver.DriverContext, name string) (driver.Connector, error)
  • Connect(ctx context.Context, connector driver.Connector, name string) (driver.Conn, error)
  • ConnClose(conn driver.Conn) error

Use case: tracking connection leaks (missing call to conn.Close)

@inconshreveable
Copy link
Contributor

thanks for finding these holes in the interceptor. i'd be happy to take a PR for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants