-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BCUR v1 (legacy) support? #12
Comments
We currently offer no backwards compatibility with v1, but I would expect this to become rather useful/necessary. I'm glad that you proposed it, I will see if I can prioritize this. |
I think the consensus is to move away from UR1 in favor of UR2. See discussion here: BlockchainCommons/Gordian-Developer-Community#26 That said, for backward compatibility with Cobo Vault I have two files here that should be compatible: I have these pinned to the commit since I am updating those files in favor of UR2. |
I'm looking to use this library to generate a PSBT QR gif for airgap signing. When looking at what Specter-Desktop or Sparrow generate for PSBTs it's of the form (for legacy encoding):
Looking at the tests/examples, is this supported in your library? I do see this example, but it doesn't match the legacy
ur:bytes...
format:mofn
(i.e,2of8
). Instead, it appears that a-
is being used.Is it possible to use this library to produce/consume a QR that a HWW/Coordinator could understand for legacy encoding/decoding? A working example would be very helpful.
I'm hoping to be able to make it work with an older Cobo Vault (whose firmware can unfortunately never be updated).
(Sorry for the multiple edits, I bumped submit earlier while drafting this post and updated it. And I realized while writing this that I think this is a BCUR2 library and not a BCUR1 library which was causing some of my confusion).
The text was updated successfully, but these errors were encountered: