Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use typedefs and define structs in some places #10

Open
dlyongemallo opened this issue Apr 24, 2019 · 1 comment
Open

use typedefs and define structs in some places #10

dlyongemallo opened this issue Apr 24, 2019 · 1 comment
Labels
wontfix This will not be worked on

Comments

@dlyongemallo
Copy link
Contributor

dlyongemallo commented Apr 24, 2019

I'm not sure why s_type is defined the way it is, rather than using MKL_Complex8 from the MKL?

There are also a couple of places where a parameter or return value is a vector, when maybe it should be a struct.

I think there are also some places where ints should be size_ts or vice versa, to allow compilation on different architectures, but I will need to do some more investigation.

@dlyongemallo
Copy link
Contributor Author

Grid coordinates should be pair<int> not vector<int>. It should probably be a typedef as well.

@s-mandra s-mandra added the wontfix This will not be worked on label Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants