Skip to content
This repository has been archived by the owner on Jun 14, 2018. It is now read-only.

Add type="button" to uifDialog #392

Closed
ghost opened this issue Jul 19, 2016 · 2 comments
Closed

Add type="button" to uifDialog #392

ghost opened this issue Jul 19, 2016 · 2 comments

Comments

@ghost
Copy link

ghost commented Jul 19, 2016

See #374 for more information. type="button" needs adding to the <button> elements

@ghost
Copy link
Author

ghost commented Dec 15, 2016

picking back up @andrewconnell, can you change label?

@andrewconnell
Copy link
Member

I'm going to close this... I think fundamentally we need to revisit the dialog... see #455 ... I think our initial implementation is flawed and overly complex... we should bite the bullet and redo it to match the way the react component works.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant