Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special Characters at end of url are not recognized as part of it #465

Closed
lepult opened this issue Nov 29, 2023 · 2 comments
Closed

Special Characters at end of url are not recognized as part of it #465

lepult opened this issue Nov 29, 2023 · 2 comments

Comments

@lepult
Copy link

lepult commented Nov 29, 2023

Special Characters at the end of a URL aren't recognised as a part of it, even though they should be. If a letter is added after the special character, it is recognised as part of the url.

Example:

linkify.find('test.com/?test=)'); // returns object with value === "test.com/?test=". Expected closing bracket at end of it.
linkify.find('test.com/?test=)a'); // returns object with value === "test.com/?test=)a"
@CHOYSEN
Copy link

CHOYSEN commented Sep 12, 2024

any updates?

@nfrasser
Copy link
Owner

nfrasser commented Dec 4, 2024

Hi @lepult and @CHOYSEN, apologies for the delay. This is unfortunately the intended behaviour. Specifically, URLs cannot end in a closing parentheses. You'll notice that Github's autolink works similarly: http://test.com/?test=)

I will accept pull requests if anyone wants to implementing a workable solution to this, but for now I'm marking this as not planned.

@nfrasser nfrasser closed this as not planned Won't fix, can't repro, duplicate, stale Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants