Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdUnit path as well as the slot size remains but the page results changes in that case the new slot is not created #80

Open
mdshaheer opened this issue May 16, 2018 · 1 comment

Comments

@mdshaheer
Copy link

I have a scenario in my project where in I navigate from Listing page to Listing page and will change the results. For each of these actions we are making a DFP call to get new Ads. But as the AdUnitPath and Slot size remains the same am not seeing we are destroying the old slot and adding a new one hence the slot remains blank.
Do you think you have a fix for the same? Previously before using react-gpt when I was doing the implementation by my own I was adding the timestamp for the div Id to make sure every time I call DFP i will call with new id.

@mdshaheer mdshaheer changed the title AdUnit path as well as the slot size remains but the page results same the new slot is not created AdUnit path as well as the slot size remains but the page results changes in that case the new slot is not created May 17, 2018
@potench
Copy link
Contributor

potench commented May 18, 2018

Can you provide some sample code or a test case in the tests that shows this happening?
https://github.com/nfl/react-gpt/blob/60f6ce0ccd02e3c423b772b42de50ba776d883e7/docs/Guides.md#refresh-vs-re-render
If no props are changing (you said same adUnitPath and size) then you probably need to call Bling.refresh()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants