Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for googletag.PassbackSlot #70

Open
iamdhrooov opened this issue Jan 8, 2018 · 2 comments
Open

Support for googletag.PassbackSlot #70

iamdhrooov opened this issue Jan 8, 2018 · 2 comments

Comments

@iamdhrooov
Copy link

Do you have plans to add support for passback tags for third-party ad networks?

@potench
Copy link
Contributor

potench commented Jan 8, 2018

None right now, but this seems like a feature that wouldn't be difficult to add: https://support.google.com/dfp_premium/answer/2811375?hl=en

Maybe by adding the following props to Bling:

<Bling 
    passbackUrl={`// String (required) URL`}
    passbackPageUrl={`// String (optional) URL`}
    passbackTargeting={
        // Array (optional)
        [{"color": "red"}, {"sport": ["rugby", "rowing"]}]  (like existing `targeting` prop)
    }
    passbackClickUrl={`// String (optional)`}
/>

Or with an optional passback object prop

<Bling passback={{
     url: string,
     pageUrl: string,
     targeting: array
     clickUrl: string 
  }} />

Which API looks better of the above 2?

@harish-aka-shivi
Copy link

The second one looks better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants