Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Technology Platform field breaks on reading if it contains a ( #571

Closed
HLWeil opened this issue Nov 18, 2024 · 3 comments · Fixed by nfdi4plants/ARCtrl#477 or #573
Closed

[Bug]: Technology Platform field breaks on reading if it contains a ( #571

HLWeil opened this issue Nov 18, 2024 · 3 comments · Fixed by nfdi4plants/ARCtrl#477 or #573
Labels
Type: Bug Something is not working, and it is confirmed by maintainers to be a bug.

Comments

@HLWeil
Copy link
Member

HLWeil commented Nov 18, 2024

Contact Details

No response

What happened?

Create assay with the following technology type:

image

Write to xlsx, all good:

image

Read again in Swate (breaks):
image

What did you expect?

No response

Host

Applies to All

Host Details

ARCitect 0.0.49 and Standalone SWATE

Swate version

recent
@github-actions github-actions bot added the Status: Needs Triage This item is up for investigation. label Nov 18, 2024
@HLWeil
Copy link
Member Author

HLWeil commented Nov 18, 2024

Found the error, can be moved to ARCtrl.

The problem is, that the "Technology Platform" is a single string field in the isa file. To depict this as an ontology term we do some parsing magic (including ()) which breaks for terms containing ()

@HLWeil HLWeil mentioned this issue Nov 18, 2024
Merged
@github-project-automation github-project-automation bot moved this to Done in ARCStack Nov 18, 2024
@Freymaurer Freymaurer mentioned this issue Nov 19, 2024
Merged
@HLWeil
Copy link
Member Author

HLWeil commented Nov 19, 2024 •
edited
Loading

Unfortunately still broken.

Did you already update the ARCtrl dependency?

@HLWeil HLWeil reopened this Nov 19, 2024
@HLWeil
Copy link
Member Author

HLWeil commented Nov 19, 2024

Ah now it works!

Sry apparently the version went live just now

@HLWeil HLWeil closed this as completed Nov 19, 2024
@HLWeil HLWeil added Type: Bug Something is not working, and it is confirmed by maintainers to be a bug. and removed Status: Needs Triage This item is up for investigation. labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Something is not working, and it is confirmed by maintainers to be a bug.
Projects
ARCStack
Status: Done
Milestone
No milestone
1 participant
@HLWeil