Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Top level entry points for js/py might need native code #470

Open
kMutagene opened this issue Nov 7, 2024 · 1 comment
Labels
help wanted Extra attention is needed Type: Feature Request This item is confirmed by the maintainers to be a request for a new feature

Comments

@kMutagene
Copy link
Member

Currently using ARCtrl in pythomn for the first time at BioHackEU24, first off it works great!

However, the API has same weird inconsistencies that i guess come from the general transpilation process. Example:

  • This is fine:

    from arctrl.arc import ARC
    ARC.from_rocrate_json_string(...)
  • This is weird:

    from arctrl.json import JsonController # <-- weird namespace
    JsonController.Investigation().from_rocrate_json_string # <-- class instantiation necessary
    ```

I'd suggest to write top-level entry points that are designed for transpiled languages only (as i suspect is the case for the JsonController module) in the native language. It is completely fine to have diverging APIs for convenience IMO, however i can see the additional maintenance overhead.

cc @HLWeil @feserm

@github-actions github-actions bot added the Status: Needs Triage This item is up for investigation. label Nov 7, 2024
@HLWeil HLWeil added help wanted Extra attention is needed Type: Feature Request This item is confirmed by the maintainers to be a request for a new feature and removed Status: Needs Triage This item is up for investigation. labels Nov 18, 2024
@HLWeil HLWeil moved this to In discussion in ARCStack Nov 18, 2024
@HLWeil
Copy link
Member

HLWeil commented Nov 18, 2024

I think it's doable, especially as this is only about 10-30 single line functions?

Would be great to have someone with knowledge about actual python libraries do it though 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed Type: Feature Request This item is confirmed by the maintainers to be a request for a new feature
Projects
Status: In discussion
Development

No branches or pull requests

2 participants