-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Evidence stats page #2695
base: main
Are you sure you want to change the base?
Evidence stats page #2695
Conversation
✅ Deploy Preview for nf-core-main-site ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
eb4e50d
to
deae273
Compare
e2798b9
to
3f9e1d7
Compare
Argument for why this isn't in nf-core/website
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given how badly outdated the current one now is, happy to merge this and incrementally improve 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs to use nf-core styling, incl. dark theme 😎
Tbh i don't think this is in a state to replace the current stats page. Too many placeholders, too little different stats and it will feel quite out of place with the current styling. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some stuff that'd be good to sort before merging:
- Side navbar is missing on mobile
- Links on home don't correspond to side nav
- Home > Views is the same as Code Stats > Repository Traffic? Delete Home > Views.
- Add note to empty pages explaining that we know they're empty.
Caution Refused to display 'https://nf-core-stats.evidence.app/' in a frame because it set 'X-Frame-Options' to 'sameorigin'. This may be a problem..? |
The latest deployment seems to work @ewels!
@mashehu I imported all the static data from the current stats page into some CSVs and recreated the plots. Feels way less half-finished now. As for styling, I'd love some help on that; the docs cover it. I don't know how the website styling works here. https://docs.evidence.dev/reference/themes-and-layouts/ |
This is the initial rewrite I threw together yesterday(emphasis on how quick this was to set up and get hacking on).
I pulled the database off mysql and tossed it in motherduck(This could also probably be a csv on hugging face or S3 if MotherDuckd wants to get greedy)
Scripts and some data: https://huggingface.co/datasets/nf-core/stats/blob/main/db/README.md(this was the hardest part getting connected to the DB 😅)
Threw the credentials in the Evidence template and it was off to the races.
https://nf-core-stats.netlify.app/
Some questions answered
At first I started out with a separate repo because I couldn't get it to
npm run dev
when I tossed it in the website repo. It's kinda of a Evidence bug, kinda an issue with npm workspaces. I tried switching to pnpm, and it just worked. That's definately a seperate debate, but just calling it out, so bear with me if that's a blocker this is a PoC.Just deployed it with their cloud offering because it was a click. They have netlify instructions or you just build it yourself.
It runs as a static site generator. I think we just stick with that while I prove out recreating the current stats page. I'm hoping there's some way to just injest the charts or components, but I think worst case scenario, we can just wrap the html in Astro, like what's happening with the old site currently. Just need to pull in the theming.
Main point is it's the kind of dev workflow that I think will let the community hack on it. It's simple, and quick to get up to speed, and I'll be excited to see what people build with it!
Closes #570 #571
Out standing Tasks and Decissions
@netlify /stats