Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 477 #481

Merged
merged 4 commits into from
Nov 11, 2024
Merged

Issue 477 #481

merged 4 commits into from
Nov 11, 2024

Conversation

nschcolnicov
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/smrnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 11, 2024 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit e32847c

+| ✅ 243 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

  • nextflow_config - Config default ignored: params.fastp_known_mirna_adapters

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-11-11 16:20:01

@nschcolnicov nschcolnicov marked this pull request as ready for review November 11, 2024 16:15
@nschcolnicov
Copy link
Contributor Author

This PR addresses #477

@atrigila
Copy link
Contributor

atrigila commented Nov 11, 2024 •
edited
Loading

Looks good, can you also (in this PR) do the post version bump to dev? https://nf-co.re/docs/nf-core-tools/pipelines/bump-version

@atrigila
Copy link
Contributor

Can you also add in docs that mirtop is hard coded to use the pre (and not pri), so users have to input that file from the beginning?

@nschcolnicov nschcolnicov merged commit 4037e4c into dev Nov 11, 2024
8 checks passed
@atrigila atrigila added this to the 2.4.1 milestone Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atrigila atrigila atrigila approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nschcolnicov @atrigila