Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev branch works only on the first sample #145

Open
loipf opened this issue Jun 17, 2024 · 5 comments
Open

dev branch works only on the first sample #145

loipf opened this issue Jun 17, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@loipf
Copy link

loipf commented Jun 17, 2024

Description of the bug

I know it is still work in progress, but the new version of this pipeline https://github.com/nf-core/rnavar/tree/dev seems really promising. However, it only takes the first sample in a sample sheet and ignores the rest for alignment with STAR.

FASTQC is still done on both samples, but STAR_ALIGN only takes the first sample, probably due to some multichannel conflict? I don't know exactly, what fixed it for me was setting the ch_star_index and ch_gtf to values using .first()? but you probably know a smoother and better way to solve this. just wanted to let you know. thanks for the nice pipeline. can be closed if you already know it.

https://github.com/nf-core/rnavar/blob/0b2c66e5b49eb25be3ce9014534be56a8955ec2b/workflows/rnavar/main.nf#L138

FASTQ_ALIGN_STAR(ch_cat_fastq,
            ch_star_index.first(),
            ch_gtf.first(),
            params.star_ignore_sjdbgtf,
            seq_platform,
            seq_center,
            ch_fasta,
            [[:],[]]) //ch_transcripts_fasta)

Command used and terminal output

nextflow run nf-core/rnavar -r dev -profile docker,test --outdir test2 --input input_sample_sheet.csv

Relevant files

input_sample_sheet.csv (your example with a second row):

sample,fastq_1,fastq_2,strandedness
GM12878,https://github.com/nf-core/test-datasets/raw/modules/data/genomics/homo_sapiens/illumina/fastq/test_rnaseq_1.fastq.gz,https://github.com/nf-core/test-datasets/raw/modules/data/genomics/homo_sapiens/illumina/fastq/test_rnaseq_2.fastq.gz,reverse
s2,https://github.com/nf-core/test-datasets/raw/modules/data/genomics/homo_sapiens/illumina/fastq/test_rnaseq_2.fastq.gz,https://github.com/nf-core/test-datasets/raw/modules/data/genomics/homo_sapiens/illumina/fastq/test_rnaseq_1.fastq.gz,reverse

System information

N E X T F L O W
version 24.04.2 build 5914

@loipf loipf added the bug Something isn't working label Jun 17, 2024
@maxulysse
Copy link
Member

@loipf Thanks a lot, I'm in the middle of refactoring, and I need to handle the references properly. sorry about that, I'll try to fix it ASAP

@loipf
Copy link
Author

loipf commented Jun 18, 2024

yes dont worry and no hurry, its a great pipeline

@loipf loipf closed this as completed Jun 18, 2024
@maxulysse maxulysse reopened this Jun 18, 2024
@maxulysse
Copy link
Member

let's keep open until it's fixed

@KristinaGagalova
Copy link

Interestingly, some of my runs got stacked at the first sample, while others ran for all of them.
I will relate my issue to this since using the dev branch solved my problems. - #150

@fmalmeida fmalmeida assigned fmalmeida and unassigned fmalmeida Nov 15, 2024
@fmalmeida
Copy link

fmalmeida commented Nov 15, 2024

Hi @maxulysse ,
I created a branch to propose a fix, converting the two channels from queue to value channel.
--> #154

I know you are in the middle of refactoring, but think that maybe would help having this integrated in parallel.

Let me know your thoughts. If this is something you want to integrate now, or prefer handling in a different way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

4 participants