Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output bigwigs with macs2 p-value signal for every base-pair #251

Open
Al-Murphy opened this issue Feb 3, 2022 · 4 comments
Open

Output bigwigs with macs2 p-value signal for every base-pair #251

Al-Murphy opened this issue Feb 3, 2022 · 4 comments
Labels
feature-request Request to add new functionality
Milestone

Comments

@Al-Murphy
Copy link

I am looking for the MACS2 p-value signal for every base-pair, similar to the bigwigs available from ROADMAP or EPIMAP.

Had a discussion with @JoseEspinosa and he thinks it may be available using the --bdg option when calling MACS2 but this is not a parameter that is currently available:

chipseq/main.nf

Lines 1135 to 1145 in 6924b66

macs2 callpeak \\
-t ${ipbam[0]} \\
-c ${controlbam[0]} \\
$broad \\
-f $format \\
-g $params.macs_gsize \\
-n $ip \\
$pileup \\
$fdr \\
$pvalue \\
--keep-dup all

@JoseEspinosa JoseEspinosa added DSL2 v2.0 feature-request Request to add new functionality and removed DSL2 v2.0 labels Mar 1, 2022
@drpatelh drpatelh added this to the 2.0 milestone Mar 2, 2022
@jcotney
Copy link

jcotney commented Mar 3, 2022

Just getting into nextflow and this would be very helpful for us as well. This has to be done after the initial callpeak command. Use bdgcmp command to compare the two bedgraphs originally generated by macs2 with the -B/--bdg and --SPMR options

This is how we have typically done this for histone mods:
macs2 callpeak -t x_norm_sorted.bam -c y-Input_norm_sorted.bam -n x -f BAM -g hs --keep-dup all --nomodel -p 1e-2 --broad --nomodel --extsize -B --SPMR
macs2 bdgcmp -t x_treat_pileup.bdg -c y_control_lambda.bdg -o x_ppois.bdg -m ppois -S <value calculated based on whether the chip or input larger/million reads>

@Al-Murphy
Copy link
Author

Just to add to @jcotney solution, ENCODE also have a pipeline to produce this data (which could be replicated in nextflow I guess):

https://github.com/ENCODE-DCC/chip-seq-pipeline2

@jcotney
Copy link

jcotney commented Mar 3, 2022

Just to add to @jcotney solution, ENCODE also have a pipeline to produce this data (which could be replicated in nextflow I guess):

https://github.com/ENCODE-DCC/chip-seq-pipeline2

This is exactly what the portion of our pipeline is based on. I think the current scale factor files that are generated for the igv sessions could be used to apply the value for the "-S" option. This routine could be added as an option to the overall pipeline with something like --generate-pvalue-bigwig ?

@JoseEspinosa
Copy link
Member

Yes, after reading a little bit my first comment was wrong. Probably we can leave this for the next iteration version 2.1. Ping @drpatelh to know which is his take on this, since it is also true that with version 2.0 of the pipeline it would be possible to tweak the parameters of macs2 callpeak and generate the pvalues tracks outside the pipeline.

@JoseEspinosa JoseEspinosa modified the milestones: 2.0, 2.1 Apr 1, 2022
@JoseEspinosa JoseEspinosa modified the milestones: 2.1, 2.2 Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request to add new functionality
Projects
None yet
Development

No branches or pull requests

4 participants