Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppDef for Ellipsometry #106

Open
sanbrock opened this issue Mar 2, 2022 · 4 comments
Open

AppDef for Ellipsometry #106

sanbrock opened this issue Mar 2, 2022 · 4 comments
Assignees

Comments

@sanbrock
Copy link

sanbrock commented Mar 2, 2022

https://github.com/FAIRmat-Experimental/nexus_definitions/tree/fairmat

@prjemian
Copy link
Contributor

prjemian commented Mar 2, 2022

The new definition should be added to the contributed_definitions folder of the definitions repository (in a branch or fork). Once ratified by the NIAC (item 3 of NeXus Constitution), it will be moved to the applications folder.

The pull request should be made to the definitions repository.

@sanbrock
Copy link
Author

sanbrock commented Mar 3, 2022

@cmmngr
Copy link

cmmngr commented Mar 3, 2022

We reused base classes and added fields relevant to ellipsometry experiments, but neither did we modify any existing base classes nor created any new ones.

@prjemian
Copy link
Contributor

prjemian commented Mar 4, 2022

Keep in mind that the first line of the <doc> element should be all on one line. It is used on this page to provide a rapid summary of each definition: https://manual.nexusformat.org/classes/applications/index.html#application-definitions
The one-line for ellipsometry could be just the first sentence.

The remainder in the next paragraph (with a blank line between).

@sanbrock sanbrock self-assigned this Sep 14, 2022
@sanbrock sanbrock moved this to Done in NIAC2022 project Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants