Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(packages): validation state deprecated, isInvalid prop adjusted #1631

Merged
merged 1 commit into from
Sep 16, 2023

Conversation

jrgarciadev
Copy link
Member

@jrgarciadev jrgarciadev commented Sep 15, 2023

📝 Description

The validationState was deprecated by react-aria team in favour of isInvalid. This PR adapts the isInvalid prop to work as validationState="invalid", some improvements were added.

💣 Is this a breaking change (Yes/No): No

📝 Additional Information

https://github.com/nextui-org/nextui/assets/30373425/a52a3329-4351-4b7b-8147-949b209b43c2
https://github.com/nextui-org/nextui/assets/30373425/b5910263-cde0-4f97-ac63-7aaa4d017c16

@changeset-bot
Copy link

changeset-bot bot commented Sep 15, 2023

🦋 Changeset detected

Latest commit: 546a835

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@nextui-org/checkbox Patch
@nextui-org/select Patch
@nextui-org/input Patch
@nextui-org/radio Patch
@nextui-org/theme Patch
@nextui-org/modal Patch
@nextui-org/table Patch
@nextui-org/react Patch
@nextui-org/navbar Patch
@nextui-org/popover Patch
@nextui-org/tabs Patch
@nextui-org/accordion Patch
@nextui-org/avatar Patch
@nextui-org/badge Patch
@nextui-org/button Patch
@nextui-org/card Patch
@nextui-org/chip Patch
@nextui-org/code Patch
@nextui-org/divider Patch
@nextui-org/dropdown Patch
@nextui-org/image Patch
@nextui-org/kbd Patch
@nextui-org/link Patch
@nextui-org/listbox Patch
@nextui-org/menu Patch
@nextui-org/pagination Patch
@nextui-org/progress Patch
@nextui-org/ripple Patch
@nextui-org/scroll-shadow Patch
@nextui-org/skeleton Patch
@nextui-org/snippet Patch
@nextui-org/spacer Patch
@nextui-org/spinner Patch
@nextui-org/switch Patch
@nextui-org/tooltip Patch
@nextui-org/user Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextui-docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 15, 2023 8:36pm
nextui-storybook-v2 ✅ Ready (Inspect) Visit Preview Sep 15, 2023 8:36pm

@jrgarciadev jrgarciadev merged commit 425a034 into main Sep 16, 2023
6 checks passed
@jrgarciadev jrgarciadev deleted the fix/validationState branch September 16, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants