fix: resolved overlap issue with arrow in select #1591
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d429516 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@jguddas is attempting to deploy a commit to the NextUI Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jrgarciadev
reviewed
Sep 10, 2023
jguddas
commented
Oct 5, 2023
jrgarciadev
requested changes
Oct 5, 2023
| @@ -9,9 +9,9 @@ const select = tv({ | |||
| label: "block text-small font-medium text-foreground-500 pointer-events-none", | |||
| mainWrapper: "w-full flex flex-col", | |||
| trigger: | |||
| "relative px-3 gap-3 w-full inline-flex flex-row items-center shadow-sm outline-none tap-highlight-transparent", | |||
| "relative px-3 gap-3 w-full inline-flex flex-row items-center shadow-sm outline-none tap-highlight-transparent pr-10", | |||
There was a problem hiding this comment.
@jguddas let's reduce the pr to 6, please check this line https://github.com/nextui-org/nextui/pull/1591/files#diff-cf57aaf38eadf5556e28ffe5f5cd170c1b121821a248be7d551d02c13025b0c4L88
The px overrides the pr- on sm sizes
|
Closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the content could grow until it was under the arrow.
Now: