Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/1561 #1563

Merged
merged 2 commits into from
Sep 3, 2023
Merged

Fix/1561 #1563

merged 2 commits into from
Sep 3, 2023

Conversation

jrgarciadev
Copy link
Member

Closes #1561

📝 Description

Select component has an extra white space which the Input does not have. It make using them in the same layout more difficult as necessary.

⛳️ Current behavior (updates)

Select has a bottom space when including helper components

🚀 New behavior

Bottom space removed

💣 Is this a breaking change (Yes/No): No

📝 Additional Information

@changeset-bot
Copy link

changeset-bot bot commented Sep 3, 2023

🦋 Changeset detected

Latest commit: c2848f2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@nextui-org/theme Patch
@nextui-org/accordion Patch
@nextui-org/avatar Patch
@nextui-org/badge Patch
@nextui-org/button Patch
@nextui-org/card Patch
@nextui-org/checkbox Patch
@nextui-org/chip Patch
@nextui-org/code Patch
@nextui-org/divider Patch
@nextui-org/dropdown Patch
@nextui-org/image Patch
@nextui-org/input Patch
@nextui-org/kbd Patch
@nextui-org/link Patch
@nextui-org/listbox Patch
@nextui-org/menu Patch
@nextui-org/modal Patch
@nextui-org/navbar Patch
@nextui-org/pagination Patch
@nextui-org/popover Patch
@nextui-org/progress Patch
@nextui-org/radio Patch
@nextui-org/ripple Patch
@nextui-org/scroll-shadow Patch
@nextui-org/select Patch
@nextui-org/skeleton Patch
@nextui-org/snippet Patch
@nextui-org/spacer Patch
@nextui-org/spinner Patch
@nextui-org/switch Patch
@nextui-org/table Patch
@nextui-org/tabs Patch
@nextui-org/tooltip Patch
@nextui-org/user Patch
@nextui-org/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextui-docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2023 0:43am
nextui-storybook-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2023 0:43am

@jrgarciadev jrgarciadev merged commit a3be419 into main Sep 3, 2023
6 checks passed
@jrgarciadev jrgarciadev deleted the fix/1561 branch September 3, 2023 13:19
jguddas pushed a commit to jguddas/nextui that referenced this pull request Sep 8, 2023
* fix(select): bottom space

* chore(select): changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Select component has unexpectedly large bottom white space
1 participant