fix(dropdown): unnecessary ref in dropdown (#4278)

nextui-org · Dec 8, 2024 · 26b33a5 · 26b33a5
1 parent b16291b
commit 26b33a5
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 9 deletions.
diff --git a/.changeset/soft-pugs-travel.md b/.changeset/soft-pugs-travel.md
@@ -0,0 +1,5 @@
+---
+"@nextui-org/dropdown": patch
+---
+
+fix unnecessary ref in dropdown (#4245)
diff --git a/packages/components/dropdown/src/use-dropdown.ts b/packages/components/dropdown/src/use-dropdown.ts
@@ -164,18 +164,12 @@ export function useDropdown(props: UseDropdownProps): UseDropdownReturn {
     };
   };
 
-  const getMenuTriggerProps: PropGetter = (
-    originalProps = {},
-    _ref: Ref<any> | null | undefined = null,
-  ) => {
+  const getMenuTriggerProps: PropGetter = (originalProps = {}) => {
     // These props are not needed for the menu trigger since it is handled by the popover trigger.
     // eslint-disable-next-line @typescript-eslint/no-unused-vars
     const {onPress, onPressStart, ...otherMenuTriggerProps} = menuTriggerProps;
 
-    return {
-      ...mergeProps(otherMenuTriggerProps, {isDisabled}, originalProps),
-      ref: mergeRefs(_ref, triggerRef),
-    };
+    return mergeProps(otherMenuTriggerProps, {isDisabled}, originalProps);
   };
 
   const getMenuProps = <T extends object>(
@@ -225,5 +219,5 @@ export type UseDropdownReturn = {
   disableAnimation: boolean;
   getPopoverProps: PropGetter;
   getMenuProps: <T extends object>(props?: Partial<MenuProps<T>>, ref?: Ref<any>) => MenuProps;
-  getMenuTriggerProps: (props?: any, ref?: Ref<any>) => any;
+  getMenuTriggerProps: (props?: any) => any;
 };