Rule Builder filter step causes a syntax error?

[Coooz]

Hi,

In a Source Filter Rule Builder step, I drag MSH.9.2 from the message tree to the Field box, set Condition to Equals, and provide the 'R01' value. The generated JavaScript is as follows:

if (msg['MSH']['MSH.9']['MSH.9.2'].toString() == 'R01') {
    return true;
}
return false;

I click on Validate Rule, and the validation is successful. I save the changes and deploy the channel.

The following errors appear in the Server Log tab:

[2022-05-17 02:52:10,318]  ERROR  (com.mirth.connect.server.channel.ErrorTaskHandler:25): com.mirth.connect.donkey.server.DeployException: Error initializing JavaScript Filter/Transformer

	at com.mirth.connect.server.controllers.DonkeyEngineController$DeployTask.doDeploy(DonkeyEngineController.java:1827)

	at com.mirth.connect.server.controllers.DonkeyEngineController$DeployTask.execute(DonkeyEngineController.java:1805)

	at com.mirth.connect.server.channel.ChannelTask.call(ChannelTask.java:67)

	at com.mirth.connect.server.channel.ChannelTask.call(ChannelTask.java:16)

	at java.util.concurrent.FutureTask.run(Unknown Source)

	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)

	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)

	at java.lang.Thread.run(Unknown Source)
Caused by: com.mirth.connect.server.transformers.JavaScriptInitializationException: Error initializing JavaScript Filter/Transformer

	at com.mirth.connect.server.transformers.JavaScriptFilterTransformer.initialize(JavaScriptFilterTransformer.java:80)

	at com.mirth.connect.server.transformers.JavaScriptFilterTransformer.<init>(JavaScriptFilterTransformer.java:58)

	at com.mirth.connect.server.controllers.DonkeyEngineController.createFilterTransformerExecutor(DonkeyEngineController.java:1435)

	at com.mirth.connect.server.controllers.DonkeyEngineController.createSourceConnector(DonkeyEngineController.java:1374)

	at com.mirth.connect.server.controllers.DonkeyEngineController.createChannelFromModel(DonkeyEngineController.java:1153)

	at com.mirth.connect.server.controllers.DonkeyEngineController$DeployTask.doDeploy(DonkeyEngineController.java:1825)

	... 7 more
Caused by: java.lang.Exception: com.mirth.connect.server.MirthJavascriptTransformerException: 
SCRIPT SOURCE:
	2ca98322-8f31-48cc-8e8c-956e447c9e88
SOURCE CODE:
	
200: function filterRule1() {
201: if(msg['MSH']['MSH.9']['MSH.9.2'].toString() == 'R01') {
202: 
	return true;
203: }
204: return false;
205: }function doFilter() { phase[0] = 'filter'; return ( && (filterRule1() == true)); }
206: function doTransform() { phase[0] = 'transformer'; logger = Packages.org.apache.log4j.Logger.getLogger(phase[0]);
207: 
208: 
209: if ('xml' === typeof msg) {
LINE NUMBER:
	205
LINE SOURCE:
	}function doFilter() { phase[0] = 'filter'; return ( && (filterRule1() == true)); }
DETAILS:
	syntax error


	at com.mirth.connect.server.util.javascript.JavaScriptUtil.compileAndAddScript(JavaScriptUtil.java:670)

	at com.mirth.connect.server.transformers.JavaScriptFilterTransformer.initialize(JavaScriptFilterTransformer.java:72)

	... 12 more
Caused by: com.mirth.connect.server.MirthJavascriptTransformerException: 
SCRIPT SOURCE:
	2ca98322-8f31-48cc-8e8c-956e447c9e88
SOURCE CODE:
	
200: function filterRule1() {
201: if(msg['MSH']['MSH.9']['MSH.9.2'].toString() == 'R01') {
202: 
	return true;
203: }
204: return false;
205: }function doFilter() { phase[0] = 'filter'; return ( && (filterRule1() == true)); }
206: function doTransform() { phase[0] = 'transformer'; logger = Packages.org.apache.log4j.Logger.getLogger(phase[0]);
207: 
208: 
209: if ('xml' === typeof msg) {
LINE NUMBER:
	205
LINE SOURCE:
	}function doFilter() { phase[0] = 'filter'; return ( && (filterRule1() == true)); }
DETAILS:
	syntax error


	at com.mirth.connect.server.util.javascript.JavaScriptUtil.compileAndAddScript(JavaScriptUtil.java:669)

	... 13 more

and

[2022-05-17 02:52:10,318]  ERROR  (com.mirth.connect.server.transformers.JavaScriptFilterTransformer:79): Filter/Transformer error
java.lang.Exception: com.mirth.connect.server.MirthJavascriptTransformerException: 
SCRIPT SOURCE:
	2ca98322-8f31-48cc-8e8c-956e447c9e88
SOURCE CODE:
	
200: function filterRule1() {
201: if(msg['MSH']['MSH.9']['MSH.9.2'].toString() == 'R01') {
202: 
	return true;
203: }
204: return false;
205: }function doFilter() { phase[0] = 'filter'; return ( && (filterRule1() == true)); }
206: function doTransform() { phase[0] = 'transformer'; logger = Packages.org.apache.log4j.Logger.getLogger(phase[0]);
207: 
208: 
209: if ('xml' === typeof msg) {
LINE NUMBER:
	205
LINE SOURCE:
	}function doFilter() { phase[0] = 'filter'; return ( && (filterRule1() == true)); }
DETAILS:
	syntax error


	at com.mirth.connect.server.util.javascript.JavaScriptUtil.compileAndAddScript(JavaScriptUtil.java:670)

	at com.mirth.connect.server.transformers.JavaScriptFilterTransformer.initialize(JavaScriptFilterTransformer.java:72)

	at com.mirth.connect.server.transformers.JavaScriptFilterTransformer.<init>(JavaScriptFilterTransformer.java:58)

	at com.mirth.connect.server.controllers.DonkeyEngineController.createFilterTransformerExecutor(DonkeyEngineController.java:1435)

	at com.mirth.connect.server.controllers.DonkeyEngineController.createSourceConnector(DonkeyEngineController.java:1374)

	at com.mirth.connect.server.controllers.DonkeyEngineController.createChannelFromModel(DonkeyEngineController.java:1153)

	at com.mirth.connect.server.controllers.DonkeyEngineController$DeployTask.doDeploy(DonkeyEngineController.java:1825)

	at com.mirth.connect.server.controllers.DonkeyEngineController$DeployTask.execute(DonkeyEngineController.java:1805)

	at com.mirth.connect.server.channel.ChannelTask.call(ChannelTask.java:67)

	at com.mirth.connect.server.channel.ChannelTask.call(ChannelTask.java:16)

	at java.util.concurrent.FutureTask.run(Unknown Source)

	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)

	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)

	at java.lang.Thread.run(Unknown Source)
Caused by: com.mirth.connect.server.MirthJavascriptTransformerException: 
SCRIPT SOURCE:
	2ca98322-8f31-48cc-8e8c-956e447c9e88
SOURCE CODE:
	
200: function filterRule1() {
201: if(msg['MSH']['MSH.9']['MSH.9.2'].toString() == 'R01') {
202: 
	return true;
203: }
204: return false;
205: }function doFilter() { phase[0] = 'filter'; return ( && (filterRule1() == true)); }
206: function doTransform() { phase[0] = 'transformer'; logger = Packages.org.apache.log4j.Logger.getLogger(phase[0]);
207: 
208: 
209: if ('xml' === typeof msg) {
LINE NUMBER:
	205
LINE SOURCE:
	}function doFilter() { phase[0] = 'filter'; return ( && (filterRule1() == true)); }
DETAILS:
	syntax error


	at com.mirth.connect.server.util.javascript.JavaScriptUtil.compileAndAddScript(JavaScriptUtil.java:669)

	... 13 more

A syntax error, no less. Now how can that possibly be? Am I overlooking something? I use Mirth 3.12.

EDIT:
I found this occurs if it is not the first step and the first step is disabled. It may have something to do with that.

[pacmano1]

Read #4470 please.

[pacmano1]

the "OR" or "AND" on the second step fails because the first step is disabled.

[Coooz]

Yes, that's clear. Thanks for replying!