Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print out stdout and stderr of tests on SIGTERM #1208

Closed
sunshowers opened this issue Jan 8, 2024 · 0 comments · Fixed by #1211
Closed

Print out stdout and stderr of tests on SIGTERM #1208

sunshowers opened this issue Jan 8, 2024 · 0 comments · Fixed by #1211

Comments

@sunshowers
Copy link
Member

sunshowers commented Jan 8, 2024 •
edited
Loading

While attempting to diagnose oxidecomputer/omicron#4779, we found it hard to do so because nextest does not show the output of running tests on SIGTERM.

We don't print out the stdout and stderr of tests on SIGINT, because it is quite ugly to do so on Ctrl-C (though maybe we should write stdout and stderr to a file). However, SIGTERM almost always means an automated system like a CI timeout killing nextest, so we should print out the output in that case.
@sunshowers sunshowers mentioned this issue Jan 8, 2024
Merged
sunshowers added a commit to sunshowers/nextest that referenced this issue Jan 9, 2024
@sunshowers
[nextest-runner] print outputs after SIGTERM or SIGHUP
e52aa19 
These signals are almost always generated by automation in e.g. CI.

Fixes nextest-rs#1208.
@sunshowers sunshowers mentioned this issue Jan 9, 2024
Merged
sunshowers added a commit to sunshowers/nextest that referenced this issue Jan 9, 2024
@sunshowers
[nextest-runner] print outputs after SIGTERM or SIGHUP
0c9fe57 
These signals are almost always generated by automation in e.g. CI.

Fixes nextest-rs#1208.
sunshowers added a commit to sunshowers/nextest that referenced this issue Jan 9, 2024
@sunshowers
[nextest-runner] print outputs after SIGTERM or SIGHUP
484a158 
These signals are almost always generated by automation in e.g. CI.

Fixes nextest-rs#1208.
sunshowers added a commit that referenced this issue Jan 9, 2024
@sunshowers
[nextest-runner] print outputs after SIGTERM or SIGHUP
720acd1 
These signals are almost always generated by automation in e.g. CI.

Fixes #1208.
sunshowers added a commit to oxidecomputer/omicron that referenced this issue Jan 9, 2024
@sunshowers
[tests] time out tests in test_all after a duration (#4780)
9fe8a3c 
We're seeing some tests in `test_all` hang forever (#4779). Set a
reasonable
upper bound on test duration.

This will also cause stdout and stderr for failing tests to be printed.
Doing
so on SIGTERM in general is tracked at
nextest-rs/nextest#1208.

Also, bump up the required nextest version to 0.9.64 to make use of the
`binary_id` predicate.
@sunshowers sunshowers mentioned this issue Jan 9, 2024
Merged
sunshowers added a commit to oxidecomputer/omicron that referenced this issue Jan 9, 2024
@sunshowers
[ci] update nextest to 0.9.67 (#4788)
45b6651 
This version of nextest has a fix for nextest-rs/nextest#1208, which we encountered while attempting to diagnose #4779.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[nextest-runner] print outputs after SIGTERM or SIGHUP sunshowers/nextest
1 participant
@sunshowers