Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open @-mention stays when navigating away #2758

Closed
nickvergessen opened this issue Jan 16, 2020 · 6 comments · Fixed by #4978
Closed

Open @-mention stays when navigating away #2758

nickvergessen opened this issue Jan 16, 2020 · 6 comments · Fixed by #4978
Assignees
Labels
1. to develop bug feature: chat 💬 Chat and system messages feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents

Comments

@nickvergessen
Copy link
Member

Steps to reproduce

  1. Share a file to a group/user
  2. Join conversation and start typing @t
  3. Navigate to another file/item/sidebar tab

Expected behaviour

Autocomplete should close

Actual behaviour

Autocomplete is stuck on this position on your screen until a page reload happens

Peek 2020-01-16 08-58

@nickvergessen nickvergessen added 0. Needs triage bug feature: chat 💬 Chat and system messages feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents 1. to develop and removed 0. Needs triage labels Jan 16, 2020
@nickvergessen nickvergessen added this to the 💚 Next Major (18) milestone Jan 16, 2020
@nickvergessen
Copy link
Member Author

cc @danxuliu if you can still have a look

@PVince81
Copy link
Member

Still happening in 11.0.0-alpha.3

@PVince81
Copy link
Member

seems the popover in that specific case is missing some handler to close when clicking outside.
doesn't matter where I click outside, it never closes.

seems to be a bug in the original library, see how in this demo it also doesn't close when clicking outside: https://fritx.github.io/vue-at/#/en/quickstart

so we'll likely need to write our own "click outside" handler in our "AdvancedInput" component for proper closing

@PVince81
Copy link
Member

bug report still open: fritx/vue-at#114
with a potential solution to implement on our side: fritx/vue-at#114 (comment)

@PVince81
Copy link
Member

PVince81 commented Jan 20, 2021

I had a quick local try with only the blur event and while closing works by clicking outside, now clicking on a mention in the dropdown closes it too early. I had to add a setTimeout() before closing of at least 500ms... That might explain why the proposed solution of the author also involves at timer :-/

@PVince81
Copy link
Member

PR here #4978 with a timeout handler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop bug feature: chat 💬 Chat and system messages feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants