fix: skip the integrity check for nextcloud-init-sync.lock

[kesselb]

• Resolves: nextcloud-init-sync.lock fails integrity check after 29->30 docker#2299

Summary

nextcloud-init-sync.lock is used by nextcloud/docker to prevent running the initialization script on multiple containers at the same time.

TODO

• CI
• Review

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[kesselb]

/backport to stable30

[joshtrichards]

Seems fine. Though I'm mystified: why this wasn't a problem previously? It should have been a problem all along. I guess now the integrity checker is behaving how I'd expect, but I'm not sure why. 😆 The main change was #46174.

EDIT: Comparison of v29 versus v30 behavior below (empty files seem to be getting treated differently for whatever reason)

[joshtrichards]

Suggested change

	'nextcloud-init-sync.lock ' // Used by nextcloud/docker to prevent running the initialization script on multiple containers at the same time: https://github.com/nextcloud/docker/issues/2299.
	'nextcloud-init-sync.lock' // Used by nextcloud/docker to prevent running the initialization script on multiple containers at the same time: https://github.com/nextcloud/docker/issues/2299.

[kesselb]

Thanks, well spotted 🙏

[joshtrichards]

Somehow in <30 the integrity checker seemed to skip empty files I guess?

v29:

www-data@b0b680aa47f5:~/html$ ./occ integrity:check-core
www-data@b0b680aa47f5:~/html$ echo hello > hello 
www-data@b0b680aa47f5:~/html$ ./occ integrity:check-core
  - EXTRA_FILE:
    - hello:
      - expected: 
      - current: e7c22b994c59d9cf2b48e549b1e24666636045930d3da7c1acb299d1c3b7f931f94aae41edda2c2b207a36e10f8bcb8d45223e54878f5b316e7ce3b6bc019629
www-data@b0b680aa47f5:~/html$ touch empty
www-data@b0b680aa47f5:~/html$ ./occ integrity:check-core
  - EXTRA_FILE:
    - hello:
      - expected: 
      - current: e7c22b994c59d9cf2b48e549b1e24666636045930d3da7c1acb299d1c3b7f931f94aae41edda2c2b207a36e10f8bcb8d45223e54878f5b316e7ce3b6bc019629
www-data@b0b680aa47f5:~/html$ 

v30:

www-data@3155cc17714b:~/html$ ./occ integrity:check-core
  - EXTRA_FILE:
    - nextcloud-init-sync.lock:
      - expected: 
      - current: cf83e1357eefb8bdf1542850d66d8007d620e4050b5715dc83f4a921d36ce9ce47d0d13c5d85f2b0ff8318d2877eec2f63b931bd47417a81a538327af927da3e
www-data@3155cc17714b:~/html$ echo hello > hello
www-data@3155cc17714b:~/html$ ./occ integrity:check-core
  - EXTRA_FILE:
    - hello:
      - expected: 
      - current: e7c22b994c59d9cf2b48e549b1e24666636045930d3da7c1acb299d1c3b7f931f94aae41edda2c2b207a36e10f8bcb8d45223e54878f5b316e7ce3b6bc019629
    - nextcloud-init-sync.lock:
      - expected: 
      - current: cf83e1357eefb8bdf1542850d66d8007d620e4050b5715dc83f4a921d36ce9ce47d0d13c5d85f2b0ff8318d2877eec2f63b931bd47417a81a538327af927da3e
www-data@3155cc17714b:~/html$ touch empty
www-data@3155cc17714b:~/html$ ./occ integrity:check-core
  - EXTRA_FILE:
    - empty:
      - expected: 
      - current: cf83e1357eefb8bdf1542850d66d8007d620e4050b5715dc83f4a921d36ce9ce47d0d13c5d85f2b0ff8318d2877eec2f63b931bd47417a81a538327af927da3e
    - hello:
      - expected: 
      - current: e7c22b994c59d9cf2b48e549b1e24666636045930d3da7c1acb299d1c3b7f931f94aae41edda2c2b207a36e10f8bcb8d45223e54878f5b316e7ce3b6bc019629
www-data@3155cc17714b:~/html$ 

[nickvergessen]

Somehow in <30 the integrity checker seemed to skip empty files I guess?

The reason is another one, but yeah it skipped all empty ones.

[nickvergessen]

/backport to stable30

[nickvergessen]

/backport to stable29

[nickvergessen]

/backport to stable28