Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar: Remove valarms from objects in read-only shared calendars #679

Closed
tobiasKaminsky opened this issue Jul 31, 2016 · 10 comments · Fixed by #6903
Closed

Calendar: Remove valarms from objects in read-only shared calendars #679

tobiasKaminsky opened this issue Jul 31, 2016 · 10 comments · Fixed by #6903
Assignees
Milestone

Comments

@tobiasKaminsky
Copy link
Member

In ownCloud once there was a patch that removed valarms on shared calenders.
The purpose is to not be flooded by alarms by read-only shared calenders.

Ref: owncloud/core#24377

@nursoda
Copy link

nursoda commented Sep 24, 2016

My family and my colleague use NC and have their own calendars. They shared some of them read-only and some of them read-write. They set up alarm, all of them ring on my phone, but I don't want to see/hear all their reminders!

I write this since I think that the proposed "solution" doesn't eliminate the root issue. Why?

I'm a secretary. I manage appointments for my boss. I see 3 possible user expectations:

  • I also set up reminders for him (only), since that's what he expects me to do: manage all his calendar.
  • I might set up alarms in his calendar that are meant to me (like to prepare the room). One might argue, that in that case I should add an event with alarm in my own calender. OK, I can live with that.
  • Only my boss may set up reminders on his events (since it's his phone ringing then, after all).

So, I vote alarms be INDEPENDENT of the calendar status (read-only vs. read-write). Proper solutions could be to add a property that lets a user select

  • whether or not to share valarms (read-write/read-only same as calendar itself) -or-
  • whether or not to import valarms - or-
  • for which user(s) an alarms should ring.

@tobiasKaminsky
Copy link
Member Author

Closed as moved to calendar repo

@georgehrke
Copy link
Member

I know that the caldav sharing standard says something about reminders. Will have to research that

@georgehrke georgehrke self-assigned this Dec 2, 2016
@aartsr
Copy link

aartsr commented Jan 23, 2017

@georgehrke just wondering if there's any progress on this issue, it's the one thing that's stopping us from starting to use nextcloud :)

@georgehrke
Copy link
Member

So, that's the CalDAV sharing standard.

In section 5.5.4 it says:

Servers MUST support "per-user" calendar data in calendar object resources stored in shared calendars. This allows each sharee and the sharer to store their own alarms and free busy transparency status without "interfering" with other users who also have access to the same calendar object resources.

=> we need something like a calendarobjects_per_user table to store custom custom alarms and transparency settings on a per sharee basis

@nursoda
Copy link

nursoda commented Feb 26, 2017

@georgehrke To me it seems that now no bug is open to address this (nextcloud/calendar#211 is closed, too) - or I have overlooked it. Could you please check (and post a reference here)?

@georgehrke
Copy link
Member

This very bug we are commenting is open.

@vmuth
Copy link

vmuth commented Feb 28, 2017

Hi, in owncloud/core#24377 I posted a file for this issue with owncloud 9.0. I think this hack ( https://github.com/owncloud/core/files/461943/caldavbackend.php_oc90-no-Alarm-For-ReadOnly-Shared-Calender.txt ) can also be modified to work with nextcloud(?)

Have a look for "clearVALARM" in line 536 and line 586 as well as 'katinkas hack' in line 1396-1425.

It's running now in company with more than 100 employees for months now and works fine.

Maybe somebody can tell me (or send a link) how to check in these lines in the code base? :)

@jkalousek
Copy link

jkalousek commented Mar 21, 2017

@vmuth solution seems almost right but for my use case it would need to be applied to all calendars because I have multiple users, all with write access but I don't want any reminders to be shared between them (so each of them can setup theirs personal reminders). So maybe option to filter out any reminder synchronization between calendars?

EDIT: I looked up into the code. Is it possible (as temporary fix) to edit fction "updateShares" in "CalDavBackend.php" so it strips out alarm data while syncing?

@nursoda
Copy link

nursoda commented Mar 22, 2017

Please do add a milestone to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants