diff --git a/apps/files_sharing/lib/Helper.php b/apps/files_sharing/lib/Helper.php index 3f1937396a01e..92abebb4af315 100644 --- a/apps/files_sharing/lib/Helper.php +++ b/apps/files_sharing/lib/Helper.php @@ -22,18 +22,17 @@ public static function registerHooks() { * check if file name already exists and generate unique target * * @param string $path - * @param array $excludeList * @param View $view * @return string $path */ - public static function generateUniqueTarget($path, $excludeList, $view) { + public static function generateUniqueTarget($path, $view) { $pathinfo = pathinfo($path); $ext = isset($pathinfo['extension']) ? '.' . $pathinfo['extension'] : ''; $name = $pathinfo['filename']; $dir = $pathinfo['dirname']; $i = 2; - while ($view->file_exists($path) || in_array($path, $excludeList)) { - $path = Filesystem::normalizePath($dir . '/' . $name . ' (' . $i . ')' . $ext); + while ($view->file_exists($path)) { + $path = Filesystem::normalizePath($dir . '/' . $name . ' ('.$i.')' . $ext); $i++; } diff --git a/apps/files_sharing/lib/ShareBackend/File.php b/apps/files_sharing/lib/ShareBackend/File.php index 93f98c9e18a63..4d93232b6389e 100644 --- a/apps/files_sharing/lib/ShareBackend/File.php +++ b/apps/files_sharing/lib/ShareBackend/File.php @@ -65,18 +65,12 @@ public function getFilePath($itemSource, $uidOwner) { * * @param string $itemSource * @param string $shareWith - * @param array $exclude (optional) * @return string */ - public function generateTarget($itemSource, $shareWith, $exclude = null) { + public function generateTarget($itemSource, $shareWith) { $shareFolder = \OCA\Files_Sharing\Helper::getShareFolder(); $target = \OC\Files\Filesystem::normalizePath($shareFolder . '/' . basename($itemSource)); - // for group shares we return the target right away - if ($shareWith === false) { - return $target; - } - \OC\Files\Filesystem::initMountPoints($shareWith); $view = new \OC\Files\View('/' . $shareWith . '/files'); @@ -91,9 +85,7 @@ public function generateTarget($itemSource, $shareWith, $exclude = null) { } } - $excludeList = is_array($exclude) ? $exclude : []; - - return \OCA\Files_Sharing\Helper::generateUniqueTarget($target, $excludeList, $view); + return \OCA\Files_Sharing\Helper::generateUniqueTarget($target, $view); } public function formatItems($items, $format, $parameters = null) { diff --git a/lib/public/Share_Backend.php b/lib/public/Share_Backend.php index 794d72b787336..0fa79854e1084 100644 --- a/lib/public/Share_Backend.php +++ b/lib/public/Share_Backend.php @@ -30,14 +30,14 @@ public function isValidSource($itemSource, $uidOwner); * Get a unique name of the item for the specified user * @param string $itemSource * @param string|false $shareWith User the item is being shared with - * @param array|null $exclude List of similar item names already existing as shared items @deprecated 7.0.0 * @return string Target name * * This function needs to verify that the user does not already have an item with this name. * If it does generate a new name e.g. name_# * @since 5.0.0 + * @deprecated 31.0.0 */ - public function generateTarget($itemSource, $shareWith, $exclude = null); + public function generateTarget($itemSource, $shareWith); /** * Converts the shared item sources back into the item in the specified format