Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to more generic way of parsing wopi discovery #2677

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Move to more generic way of parsing wopi discovery #2677

wants to merge 8 commits into from
+1,483 −34

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Dec 9, 2022 •
edited
Loading

Refactoring of WOPI discovery use the non-deprecated actions

This is also a first step to abandon https://github.com/nextcloud/officeonline so we don't need to maintain two different apps. Other than that for compatibility with other WOPi server we would need to:

  • Do not require the capabilities endpoint to setup a server
  • Add compatibility mode setting for enabling generic wopi compatibility with limited functionality -> We can detect this based on if a capabilities endpoint is provided in discovery
  • Add WOPI validator CI step
  • Implement native locking if files_lock is not enabled

Relevant file locking related work:

@juliusknorr
Copy link
Member Author

/rebase

@cypress
Copy link

cypress bot commented Jan 5, 2023 •
edited
Loading


Test summary

17 • 0 • 0 • 0

Run details
Project Richdocuments
Status Passed
Commit 6f9402c
Started Jan 5, 2023 4:17 PM
Ended Jan 5, 2023 4:21 PM
Duration 03:37 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@juliusknorr juliusknorr force-pushed the enh/wopi branch 2 times, most recently from 6f9402c to bf6b417 Compare January 12, 2023 08:32
@juliusknorr juliusknorr added enhancement New feature or request 2. developing Work in progress labels Apr 6, 2023
@juliusknorr juliusknorr force-pushed the enh/wopi branch 2 times, most recently from 71303c7 to bde0f1d Compare November 29, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elzody elzody Awaiting requested review from elzody elzody will be requested when the pull request is marked ready for review elzody is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
2. developing Work in progress enhancement New feature or request
Projects
📝 Office team
Status: 🧭 Planning evaluation (don't pick)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@juliusknorr