[Bug]: Public share from external storage results in Nextcloud Office GUID error #3251
Closed
6 of 8 tasks
Labels
Comments
|
Looks like in richdocuments/lib/PermissionManager.php Lines 161 to 162 in 16b5b9c Looks like this bug was probably introduced in #2579 (possibly because this code path wasn't executed if the shares were public before). Related (not the same but probably something that can be fixed at the same time): #1698 |
|
Thanks for digging that code part out. Pushed a fix in #3278 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug description
When making a public share from external storage (either mounted from administrative tools or user), the share results in a Nextcloud Office error "Error: Exception: Call to a member function getUID() on null"
This appears to be related to these issues:
nextcloud/activity#436
nextcloud/server#19996
Steps to reproduce
3.Attempt to access link
Expected behavior
Public link on external storage should work as it does on Nextcloud folder.
Installation method
Community Docker image
Nextcloud Server version
27
Operating system
Debian/Ubuntu
PHP engine version
PHP 8.1
Web server
Apache (supported)
Database engine version
PostgreSQL
Is this bug present after an update or on a fresh install?
Fresh Nextcloud Server install
Are you using the Nextcloud Server Encryption module?
Encryption is Disabled
What user-backends are you using?
Configuration report
{ "system": { "one-click-instance": true, "one-click-instance.user-limit": 100, "memcache.local": "\\OC\\Memcache\\APCu", "apps_paths": [ { "path": "\/var\/www\/html\/apps", "url": "\/apps", "writable": false }, { "path": "\/var\/www\/html\/custom_apps", "url": "\/custom_apps", "writable": true } ], "check_data_directory_permissions": false, "memcache.distributed": "\\OC\\Memcache\\Redis", "memcache.locking": "\\OC\\Memcache\\Redis", "redis": { "host": "***REMOVED SENSITIVE VALUE***", "password": "***REMOVED SENSITIVE VALUE***", "port": 6379 }, "overwritehost": "***REMOVED SENSITIVE VALUE***", "overwriteprotocol": "https", "passwordsalt": "***REMOVED SENSITIVE VALUE***", "secret": "***REMOVED SENSITIVE VALUE***", "trusted_domains": [ "localhost", "nextcloud.globaladvisors.biz" ], "datadirectory": "***REMOVED SENSITIVE VALUE***", "dbtype": "pgsql", "version": "27.1.0.7", "overwrite.cli.url": "https:\/\/nextcloud.globaladvisors.biz\/", "dbname": "***REMOVED SENSITIVE VALUE***", "dbhost": "***REMOVED SENSITIVE VALUE***", "dbport": "", "dbtableprefix": "oc_", "dbuser": "***REMOVED SENSITIVE VALUE***", "dbpassword": "***REMOVED SENSITIVE VALUE***", "installed": true, "instanceid": "***REMOVED SENSITIVE VALUE***", "maintenance": false, "loglevel": "2", "log_type": "file", "logfile": "\/var\/www\/html\/data\/nextcloud.log", "log_rotate_size": "10485760", "log.condition": { "apps": [ "admin_audit" ] }, "preview_max_x": "2048", "preview_max_y": "2048", "jpeg_quality": "60", "enabledPreviewProviders": { "1": "OC\\Preview\\Image", "2": "OC\\Preview\\MarkDown", "3": "OC\\Preview\\MP3", "4": "OC\\Preview\\TXT", "5": "OC\\Preview\\OpenDocument", "6": "OC\\Preview\\Movie", "7": "OC\\Preview\\Krita", "0": "OC\\Preview\\Imaginary" }, "enable_previews": true, "upgrade.disable-web": true, "mail_smtpmode": "smtp", "trashbin_retention_obligation": "auto, 30", "versions_retention_obligation": "auto, 30", "activity_expire_days": "30", "simpleSignUpLink.shown": false, "share_folder": "\/Shared", "one-click-instance.link": "https:\/\/nextcloud.com\/all-in-one\/", "upgrade.cli-upgrade-link": "https:\/\/github.com\/nextcloud\/all-in-one\/discussions\/2726", "updatedirectory": "\/nc-updater", "davstorage.request_timeout": 3600, "htaccess.RewriteBase": "\/", "dbpersistent": true, "files_external_allow_create_new_local": true, "trusted_proxies": "***REMOVED SENSITIVE VALUE***", "allow_local_remote_servers": true, "preview_imaginary_url": "http:\/\/nextcloud-aio-imaginary:9000", "mail_from_address": "***REMOVED SENSITIVE VALUE***", "mail_sendmailmode": "smtp", "mail_domain": "***REMOVED SENSITIVE VALUE***", "mail_smtphost": "***REMOVED SENSITIVE VALUE***", "mail_smtpport": "25", "twofactor_enforced": "true", "twofactor_enforced_groups": [], "twofactor_enforced_excluded_groups": [], "ldapProviderFactory": "OCA\\User_LDAP\\LDAPProviderFactory", "app_install_overwrite": [ "vdirsyncerui" ], "enable_file_metadata": falseList of activated Apps
Nextcloud Signing status
Nextcloud Logs
{"reqId":"n2LUX3osSXT8DoT587Ck","level":3,"time":"2023-10-12T18:10:59+00:00","remoteAddr":"192.168.0.62","user":"--","app":"index","method":"GET","url":"/index.php/apps/richdocuments/wopi/files/90961_oc7u3aa5k4ov?access_token=qTLaZ0jVGv4rWBuaNFnHpCMVIdUiTuc4&access_token_ttl=1697170254000&permission=edit","message":"Call to a member function getUID() on null in file '/var/www/html/custom_apps/richdocuments/lib/PermissionManager.php' line 162","userAgent":"COOLWSD HTTP Agent 23.05.3.1","version":"27.1.0.7","exception":{"Exception":"Exception","Message":"Call to a member function getUID() on null in file '/var/www/html/custom_apps/richdocuments/lib/PermissionManager.php' line 162","Code":0,"Trace":[{"file":"/var/www/html/lib/private/AppFramework/App.php","line":183,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[["OCA\\Richdocuments\\Controller\\WopiController"],"checkFileInfo"]},{"file":"/var/www/html/lib/private/Route/Router.php","line":315,"function":"main","class":"OC\\AppFramework\\App","type":"::","args":["OCA\\Richdocuments\\Controller\\WopiController","checkFileInfo",["OC\\AppFramework\\DependencyInjection\\DIContainer"],["90961_oc7u3aa5k4ov","richdocuments.wopi.checkFileInfo"]]},{"file":"/var/www/html/lib/base.php","line":1068,"function":"match","class":"OC\\Route\\Router","type":"->","args":["/apps/richdocuments/wopi/files/90961_oc7u3aa5k4ov"]},{"file":"/var/www/html/index.php","line":36,"function":"handleRequest","class":"OC","type":"::","args":[]}],"File":"/var/www/html/lib/private/AppFramework/Http/Dispatcher.php","Line":169,"Previous":{"Exception":"Error","Message":"Call to a member function getUID() on null","Code":0,"Trace":[{"file":"/var/www/html/custom_apps/richdocuments/lib/Controller/WopiController.php","line":246,"function":"shouldWatermark","class":"OCA\\Richdocuments\\PermissionManager","type":"->","args":[["OC\\Files\\Node\\File"],null,["OC\\Share20\\Share"]]},{"file":"/var/www/html/lib/private/AppFramework/Http/Dispatcher.php","line":230,"function":"checkFileInfo","class":"OCA\\Richdocuments\\Controller\\WopiController","type":"->","args":["90961","qTLaZ0jVGv4rWBuaNFnHpCMVIdUiTuc4"]},{"file":"/var/www/html/lib/private/AppFramework/Http/Dispatcher.php","line":137,"function":"executeController","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[["OCA\\Richdocuments\\Controller\\WopiController"],"checkFileInfo"]},{"file":"/var/www/html/lib/private/AppFramework/App.php","line":183,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[["OCA\\Richdocuments\\Controller\\WopiController"],"checkFileInfo"]},{"file":"/var/www/html/lib/private/Route/Router.php","line":315,"function":"main","class":"OC\\AppFramework\\App","type":"::","args":["OCA\\Richdocuments\\Controller\\WopiController","checkFileInfo",["OC\\AppFramework\\DependencyInjection\\DIContainer"],["90961_oc7u3aa5k4ov","richdocuments.wopi.checkFileInfo"]]},{"file":"/var/www/html/lib/base.php","line":1068,"function":"match","class":"OC\\Route\\Router","type":"->","args":["/apps/richdocuments/wopi/files/90961_oc7u3aa5k4ov"]},{"file":"/var/www/html/index.php","line":36,"function":"handleRequest","class":"OC","type":"::","args":[]}],"File":"/var/www/html/custom_apps/richdocuments/lib/PermissionManager.php","Line":162},"CustomMessage":"--"},"id":"652852099e518"}Additional info
"Well, this is embarrassing, we cannot connect to your document,"
In developer console:
"Failed to load resource: the server responded with a status of 500 ()"
https://nextcloud/apps/files_sharing/publicpreview/9ozfKfrfw2BLQsSpJg?x=1918&y=1643&a=true&file=aaa.pdf&scalingup=0
The text was updated successfully, but these errors were encountered: