From d69817604bb1d56bfcc432bff9167e457d144b85 Mon Sep 17 00:00:00 2001 From: Elizabeth Danzberger Date: Mon, 25 Nov 2024 16:16:13 -0500 Subject: [PATCH 1/2] fix: do not pass title in wopi src url Signed-off-by: Elizabeth Danzberger --- src/helpers/url.js | 3 +-- src/view/Office.vue | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src/helpers/url.js b/src/helpers/url.js index b8b654b5bf..d485e8958a 100644 --- a/src/helpers/url.js +++ b/src/helpers/url.js @@ -29,7 +29,7 @@ const getWopiSrc = (fileId) => { return wopiurl } -const getWopiUrl = ({ fileId, title, readOnly, closeButton, revisionHistory, target = undefined, startPresentation = false }) => { +const getWopiUrl = ({ fileId, readOnly, closeButton, revisionHistory, target = undefined, startPresentation = false }) => { // Only set the revision history parameter if the versions app is enabled revisionHistory = revisionHistory && window?.oc_appswebroots?.files_versions @@ -39,7 +39,6 @@ const getWopiUrl = ({ fileId, title, readOnly, closeButton, revisionHistory, tar // https://:9980/hosting/discovery return Config.get('urlsrc') + 'WOPISrc=' + encodeURIComponent(getWopiSrc(fileId)) - + '&title=' + encodeURIComponent(title) + '&lang=' + languageToBCP47() + (closeButton ? '&closebutton=1' : '') + (revisionHistory ? '&revisionhistory=1' : '') diff --git a/src/view/Office.vue b/src/view/Office.vue index 18e28447f0..2b68ae8049 100644 --- a/src/view/Office.vue +++ b/src/view/Office.vue @@ -324,7 +324,6 @@ export default { // Generate form and submit to the iframe const action = getWopiUrl({ fileId: fileid + '_' + loadState('richdocuments', 'instanceId', 'instanceid') + (version > 0 ? '_' + version : ''), - title: this.filename, readOnly: forceReadOnly || version > 0, revisionHistory: !this.isPublic, closeButton: !Config.get('hideCloseButton') && !this.isEmbedded, From 59355502a5ac7727ccd5ce575e31fdcf6aacf427 Mon Sep 17 00:00:00 2001 From: Elizabeth Danzberger Date: Mon, 25 Nov 2024 16:17:03 -0500 Subject: [PATCH 2/2] chore: `npm run lint:fix` Signed-off-by: Elizabeth Danzberger --- src/view/FilesAppIntegration.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/view/FilesAppIntegration.js b/src/view/FilesAppIntegration.js index 21dae3a160..0bbadb892d 100644 --- a/src/view/FilesAppIntegration.js +++ b/src/view/FilesAppIntegration.js @@ -149,6 +149,9 @@ export default { }, /** + * @param mimeTypeFilter + * @param insertFileProc + * @param insertHandler * @private */ insertFile_impl(mimeTypeFilter, insertFileProc, insertHandler) {