Micro text change: Remove reference to https://github.com/djmoch/nncli #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as the repo is closed Signed-off-by: Per Østergaard <[email protected]>
Signed-off-by: Per Østergaard <[email protected]>
per-oestergaard
requested review from
JuliaKirschenheuter and
enjeck
as code owners
enjeck
reviewed
Nov 26, 2024
There was a problem hiding this comment.
Even though the repo is archived, it appears the code still works and could be usable for some people. Unless we reference it at https://github.com/nextcloud/notes/wiki#3rd-party-clients too, I don't think we should remove this reference
|
I'd say this change makes sense. We should not advertise unmaintained projects to prominently. We can still have a reference with a hint that it is no longer maintained in https://github.com/nextcloud/notes/wiki |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the repo was archived Jun 18, 2024