feat: extract preview and fullscreen actions from three-dot-menu #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Pape <[email protected]>
Signed-off-by: Alexander Pape <[email protected]>
joshtrichards
added
design
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR explodes the preview/edit-toggle and the full-screen button from the three-dots menu as suggested in #366.
In the discussion it sounded like it would be an idea to only extract the preview/edit-toggle, but as only the fullscreen was left in the menu, that didn't seem reasonable.
Two screenshots what the result looks like:
Open for any feedback, the discussion in #366 has been stale for while already.