-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for attachments / images [$106] #74
Comments
If the markdown renderer would support Update: Deck is using a very similar mechanism to store attachments, we should orientate there. |
Any news? Nowadays we take notes with much more content than just text, especially since we all have mobile devices with cameras. I think is a rather basic feature. |
The other day I was reading the issues of this application and saw here that @stefan-niedermann said that the server app was lacking an API that would make possible media support for the mobile app. Since I see that @korelstar has already taken this issue into account there's no more necessity to insist on this feature, but I'd like to comment an idea from @jancborchardt that he's taken from the IOS app iA Writer, an idea to be considered once NC Notes web app will support media content, of course. In any case, whatever is the file storing model, I'm with Mr. Borchardt that the Regards. |
Yep, can only repeat what @eemantsal mentioned about iA writer. They use the |
I understand that my habits are different, yet usually I do NOT keep my images and files in the same folder of my notes. So for me it would be good to have the possibility to refer to any file stored in my Nextcloud instance via a simple syntax. A big usability bonus would be a tooltip that helps generating the syntax (a file selector that provides as output the right syntax). Two further improvements:
|
@Spartachetto development always needs to happen in small steps. :) And the first step is as we describe. Supporting images which are somewhere else is something for a further step. And an image outside of your Notes folder could for example be referred like
And combined with the #200 context-based formatting popover we can have a filepicker for inserting images. :) But all with time – and resources. Any contribution is welcome, or donations on Bountysource towards the issues: https://www.bountysource.com/issues/43586252-support-for-attachments-images |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
If you're going to complain about the lack of this feature, please do us all a favor and put your money where your mouth is (add to the bounty). Asking for features to be implemented over and over is not a developer motivator. |
Is it possible to add this issue to IssueHunt? I already have money attached there and sadly can´t move them to bountysource. :( I understand if you don´t want two different places for this, just figured I´d ask. |
The link to bountysource was configured by @jospoortvliet. Maybe he can help? I have no experiences with IssueHunt, but may be you can create the issue and post a bounty over there, too. We could link this from here. |
I'm on a Mac and am looking to see if nextcloud is a viable alternative to Apple's suite of tools; in this case the Notes app. For this particular issue, when taking notes in Apple's notes app I can take a screenshot that gets cached in the clipboard and paste it into the note using the I understand there are potential workarounds, but I presume it's the case for most people that they simply want to jot a thought down before it disappears, and while markdown* is great, for this use-case it gets in the way.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Several people have mentioned borrowing strategies from other Markdown solutions, but it might be preferable to choose one with which to develop and maintain actual cross-compatibility. That is, it could be nice if Nextcloud Notes supported using the sync folder of Joplin or QOwnNotes as a backend, specifically in the context of file attachments. Something else to add is that one route to implementing this might be borrowing from Joplin's codebase, since Joplin is written largely in JavaScript and TypeScript, which overlaps with Nextcloud Notes' use of JavaScript (but not its use of PHP). I added $15 to the bounty, but apparently we're not supposed to be using that anymore... |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Image viewing works in the Collectives app, which also displays markdown files, perhaps there is something useful to be seen there? |
@stefan-niedermann I started working on this issue. For now i am in the experimental stage, but my general approach is the following: Serverside:
Clientside: Generally, as long as the relative path resolves to a valid file accessible by the user, the api will deliver that file. So far i got 1. working, and the next goal is 3. |
Awesome! Maybe you can create a draft Pull Request so we can discuss the details with a watch on the code? (Btw i am not a developer of the server app, but i am sure @korelstar is watching this issue as well) |
Oh! I must have assumed you were involved aswell since you did the android app, but hey :D I opened a pull request |
I have now completed my base implementation. All features work, the user can upload an image and the server will display it as expected! (This is also true for images that were added from other markdown editors if they use relative links) |
@newhinton linking the server and client PR's in this issue would be very helpful. 😄 |
Sure! This is the server PR: #785 (Which is already working!) |
It would be nice to have some kind of attachment support to add an image or another file to a note
BountySource is no longer directly supported or endorsed by this repository. See #547 for more information. There is, however, an existing $136 open bounty on this issue.
The text was updated successfully, but these errors were encountered: