From b08c3520b23a12c945a80576a4fdcf9a10565029 Mon Sep 17 00:00:00 2001 From: Jesse Hitch Date: Tue, 23 Jul 2024 18:02:15 +0200 Subject: [PATCH] Apply suggestions from code review - properly exit on summary completion and fix needs for summary Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com> Signed-off-by: Jesse Hitch --- .github/workflows/lint-test.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/lint-test.yaml b/.github/workflows/lint-test.yaml index 284c7a73..da2f7693 100644 --- a/.github/workflows/lint-test.yaml +++ b/.github/workflows/lint-test.yaml @@ -115,7 +115,7 @@ jobs: summary: runs-on: ubuntu-latest-low - needs: changes + needs: [changes, run-tests] steps: - name: Summary - run: echo "All done! 🎉" + run: if ${{ needs.changes.outputs.src != 'false' && needs.run-tests.result != 'success' }}; then exit 1; fi