Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix get task by id method #12371

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix get task by id method #12371

wants to merge 2 commits into from

Conversation

SystemKeeper
Copy link
Contributor

@SystemKeeper
Copy link
Contributor Author

/backport to stable30

@SystemKeeper
Copy link
Contributor Author

/backport bc1c292 to stable29

@SystemKeeper
Copy link
Contributor Author

/backport bc1c292 to stable28

@SystemKeeper
Copy link
Contributor Author

SystemKeeper commented Nov 16, 2024 •
edited
Loading

Now that I look at it again, I think the note about ratelimit is also wrong here and only belongs to the schedule endpoint?
And it seems that status is not an int, but a string?

image

@SystemKeeper SystemKeeper mentioned this pull request Nov 16, 2024
Closed
@marcelklehr
Copy link
Member

Yes, well spotted! The POST should be a GET, the ratelimit should be for the schedule endpoint. For TaskProcessing the status is a string nowadays, indeed. Initially it was an int.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@marcelklehr marcelklehr marcelklehr approved these changes

Assignees
No one assigned
Labels
backport-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SystemKeeper @marcelklehr @Antreesy