-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(user_saml_shibboleth): Provide group information #464
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
cd5246c
to
1e041b6
Compare
This comment was marked as resolved.
This comment was marked as resolved.
1e041b6
to
94cc465
Compare
already helped to get aware of a naming and transition scenario nextcloud/user_saml#662 (comment) |
7fc7112
to
91e5d57
Compare
nextcloud/user_saml#662 extends integration tests, but that one providing the quota keeps failing, even after latest changes today. Since it works with manual testing via Keycloak, it appears this shib configuration does not provide the quota value and needs further investigation. |
da41678
to
e9e340e
Compare
- builds from nextcloud/docker-ci#464 Signed-off-by: Arthur Schiwon <[email protected]>
86da48d
to
3e5284d
Compare
Signed-off-by: Arthur Schiwon <[email protected]>
3e5284d
to
aa1843d
Compare
@juliushaertl done here. Do you want to re-review? Latest run uver at at user_saml is failing, but not anymore due to the images, it now appears to be a logic issue. Quota and Group info are all applied and delivered. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without knowing much about configuring the Sibboleth IdP itself config changes and ldif look sane from reading through it 👍
- builds from nextcloud/docker-ci#464 Signed-off-by: Arthur Schiwon <[email protected]>
- builds from nextcloud/docker-ci#464 Signed-off-by: Arthur Schiwon <[email protected]>
For nextcloud/user_saml#662
add changes to 7.3 version?So far, inside the container worked as desired: