Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(user_saml_shibboleth): Provide group information #464

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Nov 7, 2022

For nextcloud/user_saml#662

  • More testing, ensuring that groups data is indeed provided with the SAML Response at login
  • add integration tests
  • fix quota information not provided
  • add changes to 7.3 version?
  • drop first three commits
  • Publishing docker images for dirsrv and shibboleth-idp (post merge)

So far, inside the container worked as desired:

/start.sh
# wait until services are there
ldapsearch -LLL -H ldap:/// -x -D "cn=Directory Manager" -w password -b dc=idptestbed "memberof=cn=Students,ou=Groups,dc=idptestbed"
# Shows both student users
ldapsearch -LLL -H ldap:/// -x -D "cn=Directory Manager" -w password -b dc=idptestbed "(&(objectclass=groupOfNames)(member=uid=student1,ou=People*))"  cn
# shows Students and Astrophysics group, where student1 is member of

@blizzz

This comment was marked as resolved.

@blizzz blizzz force-pushed the enh/user_saml/groups branch from cd5246c to 1e041b6 Compare November 10, 2022 12:45
@blizzz

This comment was marked as resolved.

@blizzz blizzz marked this pull request as ready for review November 10, 2022 12:46
@blizzz blizzz force-pushed the enh/user_saml/groups branch from 1e041b6 to 94cc465 Compare November 10, 2022 12:48
@blizzz
Copy link
Member Author

blizzz commented Nov 14, 2022

already helped to get aware of a naming and transition scenario nextcloud/user_saml#662 (comment)

@blizzz blizzz force-pushed the enh/user_saml/groups branch from 7fc7112 to 91e5d57 Compare January 18, 2023 10:59
@blizzz
Copy link
Member Author

blizzz commented Jan 18, 2023

  • fix quota information not provided

nextcloud/user_saml#662 extends integration tests, but that one providing the quota keeps failing, even after latest changes today. Since it works with manual testing via Keycloak, it appears this shib configuration does not provide the quota value and needs further investigation.

@nickvergessen nickvergessen changed the title [user_saml_shibboleth] provide group information feat(user_saml_shibboleth): Provide group information Apr 4, 2023
@blizzz blizzz force-pushed the enh/user_saml/groups branch 2 times, most recently from da41678 to e9e340e Compare November 9, 2023 22:07
blizzz added a commit to nextcloud/user_saml that referenced this pull request Nov 10, 2023
@blizzz blizzz force-pushed the enh/user_saml/groups branch 5 times, most recently from 86da48d to 3e5284d Compare November 10, 2023 18:13
@blizzz blizzz force-pushed the enh/user_saml/groups branch from 3e5284d to aa1843d Compare November 10, 2023 18:18
@blizzz
Copy link
Member Author

blizzz commented Nov 10, 2023

@juliushaertl done here. Do you want to re-review? Latest run uver at at user_saml is failing, but not anymore due to the images, it now appears to be a logic issue. Quota and Group info are all applied and delivered.

Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without knowing much about configuring the Sibboleth IdP itself config changes and ldif look sane from reading through it 👍

@blizzz blizzz merged commit adae567 into master Nov 20, 2023
3 checks passed
@blizzz blizzz deleted the enh/user_saml/groups branch November 20, 2023 15:18
blizzz added a commit to nextcloud/user_saml that referenced this pull request Dec 1, 2023
blizzz added a commit to nextcloud/user_saml that referenced this pull request Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants