Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix adding account and skipping folder configuration crash. #7436

Merged
merged 14 commits into from
Nov 22, 2024
Merged

Fix adding account and skipping folder configuration crash. #7436

merged 14 commits into from
Nov 22, 2024

Conversation

camilasan
Copy link
Member

@camilasan camilasan commented Oct 30, 2024 •
edited
Loading

  • when adding account on mac OS and skipping the folder configuration step, it would crash and it would add an empty user as an account.
  • the dialog for configuring folder it was never going away once the user would click on skip.

@camilasan camilasan force-pushed the bugfix/accounts2 branch 2 times, most recently from 24235b5 to afc2afc Compare November 4, 2024 20:13
@camilasan camilasan changed the title WIP: Bugfix/accounts2 Fix adding account and skipping folder configuration crash. Nov 5, 2024
@camilasan camilasan marked this pull request as ready for review November 5, 2024 09:41
@camilasan
Copy link
Member Author

/backport to stable-3.14

@camilasan camilasan added this to the 3.14.5 milestone Nov 5, 2024
@Rello Rello modified the milestones: 3.14.5, 3.15.0 Nov 11, 2024
@camilasan camilasan force-pushed the bugfix/accounts2 branch 2 times, most recently from 7d44d1e to d9ed7cc Compare November 18, 2024 12:01
claucambra
claucambra approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

mgallien
mgallien requested changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@camilasan this needs a manual rebase to get it merged

@camilasan @mgallien
Use slotComputeOverallSyncStatus as a slot.
72f68aa 
- Use qAsConst.

Signed-off-by: Camila Ayres <[email protected]>
@camilasan @mgallien
Fix warning "Calling C++ methods with 'this' objects different from t…
fc75626 
…he one they were retrieved from is broken"

https://doc.qt.io/qt-6/qtqml-documents-structure.html#nativemethodbehavior

Signed-off-by: Camila Ayres <[email protected]>
@camilasan @mgallien
Modernize Account::displayName().
27ad538 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan @mgallien
Use slots as slots.
fc6ecf8 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan @mgallien
Diferentiate between display name and dav display name.
1847a2e 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan @mgallien
Rename vars: _am => _networkAccessManager, a => newAccountData.
f130e39 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan @mgallien
Use saveAccount for adding single account.
9634f4e 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan @mgallien
Add {} to single line if.
9649bd9 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan @mgallien
acc => account.
77597af 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan @mgallien
wiz => owncloudSetupWizard.
df84d12 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan @mgallien
Call for done() when skipping folder configuration.
932d615 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan @mgallien
Remove check before setting display name.
fdbda5d 
Signed-off-by: Camila Ayres <[email protected]>
@mgallien mgallien self-requested a review November 22, 2024 09:51
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7436-a7be4d752c5e870471ac67e959e4fe15e56ad76e-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit 408955e into master Nov 22, 2024
9 of 14 checks passed
@mgallien mgallien deleted the bugfix/accounts2 branch November 22, 2024 10:02
@backportbot backportbot bot mentioned this pull request Nov 22, 2024
Merged
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
15.0% Coverage on New Code (required ≥ 80%)
53 New Code Smells (required ≤ 0)
C Maintainability Rating on New Code (required ≥ A)
D Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra claucambra approved these changes

@mgallien mgallien mgallien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.15.0
Development

Successfully merging this pull request may close these issues.
5 participants
@camilasan @nextcloud-desktop-bot @mgallien @claucambra @Rello