refactor: replace QString() with QStringLiteral() for better performance #7422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integral-Tech
force-pushed
the
qstring-refactor
branch
2 times, most recently
from
6e4bc82 to
bb6a140
Compare
Signed-off-by: Integral <[email protected]>
Integral-Tech
force-pushed
the
qstring-refactor
branch
from
0772c18 to
e81a0d2
Compare
Signed-off-by: Integral <[email protected]>
Signed-off-by: Integral <[email protected]>
|
@claucambra Would you like to approve my PR? |
siblount
reviewed
Dec 17, 2024
src/gui/wizard/owncloudsetuppage.cpp
Outdated
| const auto serverDisplayString = QStringLiteral("%1 (%2)").arg(serverName, serverUrl); | ||
| _ui.comboBox->addItem(serverDisplayString, serverUrl); | ||
| _ui.comboBox->addItem(serverName, serverUrl); |
There was a problem hiding this comment.
QStringLiteral() constructs the QString object during compilation, which avoids the runtime overhead of constructing QString objects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.