Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

nextcloud / desktop Public

Notifications You must be signed in to change notification settings
Fork 812
Star 3.1k

Code
Issues 882
Pull requests 46
Discussions
Actions
Projects
Wiki
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Discussions
Actions
Projects
Wiki
Security
Insights

Rewrite communication between client and File Provider extensions using XPC#6324

Merged

claucambra merged 52 commits intomasternextcloud/desktop:masterfrom work/fileprovider-xpcnextcloud/desktop:work/fileprovider-xpcCopy head branch name to clipboard

Feb 19, 2024

+816-112

Conversation Commits52 (52)Checks Files changed

Commits

Commits on Feb 19, 2024

Add starter client communication service
claucambra
committed
Keep pointer to FileProviderExtension around in ClientCommunicationService
claucambra
committed
Add ClientCommunicationProtocol
claucambra
committed
Implement ClientCommunicationProtocol in ClientCommunicationService
claucambra
committed
Reimplement ClientCommunicationService in Swift
claucambra
committed
Properly implement listener should accept connection in ClientCommunicationService
claucambra
committed
Add starter FileProviderXPC class on client side
claucambra
committed
Add relative symlink to ClientCommunicationProtocol in srd/gui/macOS
claucambra
committed
Fix logging for fileproviderdomainmanager
claucambra
committed
Implement connection begin in XPC
claucambra
committed
Flatten FileProviderXPC::start()
claucambra
committed
Fix retain issues with domains in FileProviderXPC
claucambra
committed
Ensure FileProvider components instantiated after account setup
claucambra
committed
Add extensionAccountId property to ClientCommunicationProtocol
claucambra
committed
Cache NSXPCConnections when starting FileProviderXPC
claucambra
committed
Ensure the listener is resumed once the endpoint is created in the extension
claucambra
committed
Check for protocol type in fileproviderxpc start
claucambra
committed
Log extension id sent over XPC publicly
claucambra
committed
Retrieve extension account ids over XPC, store client comm service per account
claucambra
committed
Upon acquisition of client communication services, send account configuration
claucambra
committed
Move domain manager acquisition into separate function
claucambra
committed
Move domain url acquisition to separate function
claucambra
committed
Move acquisition of file provider services to different function
claucambra
committed
Moved XPC Utils into separate file
claucambra
committed
Clean up FileProviderXPC code, separate everything into single-responsibility methods
claucambra
committed
Fix clientcommservices datatype
claucambra
committed
Implement NSFileProviderServicing in FileProviderExtension
claucambra
committed
Extract file provider connection configuration into separate util function
claucambra
committed
Extract remote service object acquisistion from connection into separate function
claucambra
committed
Remove redundant static in anonymous fileproviderxpc utils namespace
claucambra
committed
Extract account id acquisition from clientCommService into separate function
claucambra
committed
Cast clientCommServices to NSObject with correct protocol
claucambra
committed
Add method to unauthenticate file provider extension in FileProviderXPC
claucambra
committed
Define NSDictionary types in _clientCommServices
claucambra
committed
Move extension authentication into separate method
claucambra
committed
Implement recognition of account state changing in FileProviderXPC
claucambra
committed
Fix clang-tidy namespace concatenation warning
claucambra
committed
Remove all obj-c classes from fileproviderxpc.h
claucambra
committed
Do not shadow sender()
claucambra
committed
Remove unused extension ID NSString
claucambra
committed
Use accountStateFromFileProviderDomainIdentifier method in authenticateExtension
claucambra
committed
Improve domain discovery logging
claucambra
committed
Get services using better non-url based method if available (macOS 13.0+)
claucambra
committed
Separate starting of domain manager tasks from constructor
claucambra
committed
Separate XPC init from file provider constructor
claucambra
committed
Only start XPC after file provider domains have been configured
claucambra
committed
Simplify and clarify utility of socket system for file provider
claucambra
committed
Clarify utility of xpc system for file provider
claucambra
committed
Add explainer to client interface
claucambra
committed
Simplify xpc service acquisition completion handler
claucambra
committed
Improve socket controller logging
claucambra
committed
Do not reconfigure file provider extension account if we are receiving the same details again
claucambra
committed

Footer

© 2024 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.