Create placeholder while dehydrating if needed #5890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m7913d
force-pushed
the
fixCantUpdateNonExistingPlaceholder
branch
from
4034de7 to
376a318
Compare
mgallien
requested changes
Jul 17, 2023
m7913d
force-pushed
the
fixCantUpdateNonExistingPlaceholder
branch
2 times, most recently
from
c25309a to
68fbea0
Compare
mgallien
approved these changes
Jul 18, 2023
mgallien
force-pushed
the
fixCantUpdateNonExistingPlaceholder
branch
from
68fbea0 to
96be7a3
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5890 +/- ##
==========================================
- Coverage 60.08% 60.06% -0.03%
==========================================
Files 145 145
Lines 18756 18759 +3
==========================================
- Hits 11270 11268 -2
- Misses 7486 7491 +5
|
When replacing an OnlineOnly file by another one, the file maintains it OnlineOnly pin state, but it is converted to a regular file. So, the dehydration should convert the regular file to a (dehydrated) placeholder instead of trying to update the (non-existing) placeholder. Closes nextcloud#4274 Signed-off-by: Dries Mys <[email protected]>
mgallien
force-pushed
the
fixCantUpdateNonExistingPlaceholder
branch
from
96be7a3 to
9256417
Compare
|
AppImage file: nextcloud-PR-5890-9256417612e36df64a96fff2ffe97e6f8a8fa8f7-x86_64.AppImage |
mgallien
approved these changes
Jul 20, 2023
|
/backport to stable-3.9 |
8 tasks
This was referenced Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When replacing an OnlineOnly file by another one, the file maintains it OnlineOnly pin state, but it is converted to a regular file. So, the dehydration should convert the regular file to a (dehydrated) placeholder instead of trying to update the (non-existing) placeholder.
Closes #4274
The same problem is also discussed in the following threads:
Steps to reproduce the the issue:
- Create file "a"
- Create folder "A"
- Copy file "a" to "A"
- Let the client sync the local changes to the server.
- Choose "Free up space" for "A/a" in Windows explorer
- Copy file "a" again to "A" (and let Windows replace the file)
- "Can't update non existing placeholder info" error is shown and "A/a" will indefinitely show the syncing icon.